Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 6.9 #21983

Closed
wants to merge 21 commits into from

Conversation

@targos
Copy link
Member

commented Jul 26, 2018

Let's start a new iteration!

ETA: Sept 4th, 2018

@targos

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2018

We've got a few failures!

test-postmortem-metadata

$ ./node test/v8-updates/test-postmortem-metadata.js
assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Missing constants: v8dbg_class_SharedFunctionInfo__end_position__int,v8dbg_class_SharedFunctionInfo__function_identifier__Object,v8dbg_class_SharedFunctionInfo__script__Object,v8dbg_class_SharedFunctionInfo__start_position_and_type__int,v8dbg_sharedfunctioninfo_start_position_mask,v8dbg_sharedfunctioninfo_start_position_shift
    at Object.<anonymous> (/home/mzasso/git/nodejs/canary/test/v8-updates/test-postmortem-metadata.js:48:8)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:266:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:596:3)

@nodejs/post-mortem

FreeBSD

03:26:10 In file included from ../deps/v8/src/asmjs/asm-parser.cc:5:
03:26:10 In file included from ../deps/v8/src/asmjs/asm-parser.h:12:
03:26:10 In file included from ../deps/v8/src/asmjs/asm-types.h:13:
03:26:10 In file included from ../deps/v8/src/zone/zone-containers.h:20:
03:26:10 ../deps/v8/src/zone/zone-allocator.h:57:5: error: no matching function for call to 'operator new'
03:26:10     new (v_p) U(std::forward<Args>(args)...);
03:26:10     ^~~
03:26:10 /usr/include/c++/v1/memory:1572:18: note: in instantiation of function template specialization 'v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
03:26:10             {__a.construct(__p, _VSTD::forward<_Args>(__args)...);}
03:26:10                  ^
03:26:10 /usr/include/c++/v1/memory:1453:14: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::__construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
03:26:10             {__construct(__has_construct<allocator_type, _Tp*, _Args...>(),
03:26:10              ^
03:26:10 /usr/include/c++/v1/unordered_map:1340:20: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
03:26:10     __node_traits::construct(__na, _VSTD::addressof(__h->__value_.__cc.first), __k);
03:26:10                    ^
03:26:10 /usr/include/c++/v1/unordered_map:1365:25: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::__construct_node_with_key' requested here
03:26:10     __node_holder __h = __construct_node_with_key(__k);
03:26:10                         ^
03:26:10 ../deps/v8/src/asmjs/asm-parser.cc:2220:35: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::operator[]' requested here
03:26:10       function_info->import->cache[*sig] = index;
03:26:10                                   ^
03:26:10 ../deps/v8/src/zone/zone.h:124:9: note: candidate function not viable: cannot convert argument of incomplete type 'void *' to 'v8::internal::Zone *'
03:26:10   void* operator new(size_t size, Zone* zone) { return zone->New(size); }
03:26:10         ^
03:26:10 1 error generated.

@nodejs/platform-freebsd

SmartOS

03:35:18 dtrace: failed to compile script src/v8ustack.d: line 402: failed to resolve V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER__OBJECT: Unknown variable name
03:35:18 node_dtrace_ustack.target.mk:26: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos17-64/out/Release/obj.target/node_lib/src/node_dtrace_ustack.o' failed
03:35:18 make[2]: *** [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos17-64/out/Release/obj.target/node_lib/src/node_dtrace_ustack.o] Error 1

@nodejs/platform-smartos

@targos targos added the blocked label Jul 26, 2018

@targos targos force-pushed the targos:v8-6.9 branch from cba859b to b5a187b Aug 4, 2018

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2018

I have a patch for test/v8-updates/test-postmortem-metadata.js at cjihrig@3518de8.

@targos can you cherry-pick that over? Also cc: @bmeurer and @hashseed. Can either of you confirm that my understanding of the V8 changes is correct? The commit message has an explanation for each affected constant. If these changes are correct, I'll fix the SmartOS compilation next.

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2018

I'm on holiday. Feel free to push anything to my branch

@targos targos force-pushed the targos:v8-6.9 branch 2 times, most recently from 07104cc to e0e740d Aug 19, 2018

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2018

@cjihrig Your patch doesn't apply cleanly. I tried to make your changes by hand but the test-postmortem-metadata still fails.

@refack

This comment has been minimized.

Copy link
Member

commented Aug 21, 2018

@targos @hashseed Why are these necessary?

  • build: update to renamed inspector scripts b3e924b
  • tools: update inspector_protocol 45a04fb

I thought the motivation for decoupling inspector_protocol from V8 was so that we won't have to update it concurrently with V8?

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2018

@refack decoupling inspector_protocol from V8 happened after I first opened this PR so b3e924b was already done. I assumed it wouldn't be a bad thing to update the tool but I can revert both commits if needed.

@refack

This comment has been minimized.

Copy link
Member

commented Aug 21, 2018

@refack decoupling inspector_protocol from V8 happened after I first opened this PR so b3e924b was already done. I assumed it wouldn't be a bad thing to update the tool but I can revert both commits if needed.

Thank you for the answer, I just wanted to understand.
I'm still trying to understand the levels of dependency, and whether we can refactor it out completely.

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2018

@targos, not sure what happened, but please give cjihrig@594f6b2 a shot, it should work.

@targos targos force-pushed the targos:v8-6.9 branch from 8928fe8 to 295ece7 Aug 24, 2018

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2018

@cjihrig Thanks, looks good!

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2018

@nodejs/platform-smartos v8ustack.d still needs a fix ;)

15:00:52 dtrace: failed to compile script src/v8ustack.d: line 402: failed to resolve V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER__OBJECT: Unknown variable name
15:00:52 node_dtrace_ustack.target.mk:26: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos17-64/out/Release/obj.target/node_lib/src/node_dtrace_ustack.o' failed
@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2018

I'll take care of it today.

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2018

@nodejs/platform-freebsd Anyone can help with the compilation failure?

https://ci.nodejs.org/job/node-test-commit-freebsd/20036/nodes=freebsd10-64/console

14:45:44 In file included from ../deps/v8/src/asmjs/asm-parser.cc:5:
14:45:44 In file included from ../deps/v8/src/asmjs/asm-parser.h:12:
14:45:44 In file included from ../deps/v8/src/asmjs/asm-types.h:13:
14:45:44 In file included from ../deps/v8/src/zone/zone-containers.h:20:
14:45:44 ../deps/v8/src/zone/zone-allocator.h:57:5: error: no matching function for call to 'operator new'
14:45:44     new (v_p) U(std::forward<Args>(args)...);
14:45:44     ^~~
14:45:44 /usr/include/c++/v1/memory:1572:18: note: in instantiation of function template specialization 'v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44             {__a.construct(__p, _VSTD::forward<_Args>(__args)...);}
14:45:44                  ^
14:45:44 /usr/include/c++/v1/memory:1453:14: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::__construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44             {__construct(__has_construct<allocator_type, _Tp*, _Args...>(),
14:45:44              ^
14:45:44 /usr/include/c++/v1/unordered_map:1340:20: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44     __node_traits::construct(__na, _VSTD::addressof(__h->__value_.__cc.first), __k);
14:45:44                    ^
14:45:44 /usr/include/c++/v1/unordered_map:1365:25: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::__construct_node_with_key' requested here
14:45:44     __node_holder __h = __construct_node_with_key(__k);
14:45:44                         ^
14:45:44 ../deps/v8/src/asmjs/asm-parser.cc:2220:35: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::operator[]' requested here
14:45:44       function_info->import->cache[*sig] = index;
14:45:44                                   ^
14:45:44 ../deps/v8/src/zone/zone.h:124:9: note: candidate function not viable: cannot convert argument of incomplete type 'void *' to 'v8::internal::Zone *'
14:45:44   void* operator new(size_t size, Zone* zone) { return zone->New(size); }
14:45:44         ^
14:45:44 1 error generated.
14:45:44 deps/v8/gypfiles/v8_base.target.mk:632: recipe for target '/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/asmjs/asm-parser.o' failed
@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2018

@targos here is the commit to fix the SmartOS build: cjihrig@ea184f6

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2018

@targos targos force-pushed the targos:v8-6.9 branch from 0e5c8fd to b80eb60 Aug 31, 2018

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2018

@nodejs/platform-freebsd Anyone can help with the compilation failure?

https://ci.nodejs.org/job/node-test-commit-freebsd/20036/nodes=freebsd10-64/console

14:45:44 In file included from ../deps/v8/src/asmjs/asm-parser.cc:5:
14:45:44 In file included from ../deps/v8/src/asmjs/asm-parser.h:12:
14:45:44 In file included from ../deps/v8/src/asmjs/asm-types.h:13:
14:45:44 In file included from ../deps/v8/src/zone/zone-containers.h:20:
14:45:44 ../deps/v8/src/zone/zone-allocator.h:57:5: error: no matching function for call to 'operator new'
14:45:44     new (v_p) U(std::forward<Args>(args)...);
14:45:44     ^~~
14:45:44 /usr/include/c++/v1/memory:1572:18: note: in instantiation of function template specialization 'v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44             {__a.construct(__p, _VSTD::forward<_Args>(__args)...);}
14:45:44                  ^
14:45:44 /usr/include/c++/v1/memory:1453:14: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::__construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44             {__construct(__has_construct<allocator_type, _Tp*, _Args...>(),
14:45:44              ^
14:45:44 /usr/include/c++/v1/unordered_map:1340:20: note: in instantiation of function template specialization 'std::__1::allocator_traits<v8::internal::ZoneAllocator<std::__1::__hash_node<std::__1::__hash_value_type<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int>, void *> > >::construct<const v8::internal::Signature<v8::internal::wasm::ValueType>, const v8::internal::Signature<v8::internal::wasm::ValueType> &>' requested here
14:45:44     __node_traits::construct(__na, _VSTD::addressof(__h->__value_.__cc.first), __k);
14:45:44                    ^
14:45:44 /usr/include/c++/v1/unordered_map:1365:25: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::__construct_node_with_key' requested here
14:45:44     __node_holder __h = __construct_node_with_key(__k);
14:45:44                         ^
14:45:44 ../deps/v8/src/asmjs/asm-parser.cc:2220:35: note: in instantiation of member function 'std::__1::unordered_map<v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int, v8::base::hash<v8::internal::Signature<v8::internal::wasm::ValueType> >, std::__1::equal_to<v8::internal::Signature<v8::internal::wasm::ValueType> >, v8::internal::ZoneAllocator<std::__1::pair<const v8::internal::Signature<v8::internal::wasm::ValueType>, unsigned int> > >::operator[]' requested here
14:45:44       function_info->import->cache[*sig] = index;
14:45:44                                   ^
14:45:44 ../deps/v8/src/zone/zone.h:124:9: note: candidate function not viable: cannot convert argument of incomplete type 'void *' to 'v8::internal::Zone *'
14:45:44   void* operator new(size_t size, Zone* zone) { return zone->New(size); }
14:45:44         ^
14:45:44 1 error generated.
14:45:44 deps/v8/gypfiles/v8_base.target.mk:632: recipe for target '/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/out/Release/obj.target/v8_base/deps/v8/src/asmjs/asm-parser.o' failed

This is the only thing blocking this update.

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2018

My proposition to fix this issue: #22617

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

src: add InitializeV8Platform function
This commit adds an InitializeV8Platform function which calls
v8_platform's Initialize to create the NodePlatform and also set the
structs members.

When running cctests this functions was not being called (it is called
from the Start function but that function is not called by the test
fixture.

The motivation for adding this is that I'm guessing that embedders
would might need the ability to do the same thing.

Refs: nodejs/node-v8#69

PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

tools: fix compilation after V8 upgrade
V8 now requires ICU's regular expressions.

PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

tools: remove lldbinit file from install script
V8 removed the lldbinit file.

Refs: https://crrev.com/c/1127892

PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

test: fix inspector tests after V8 upgrade
V8 improved break locations for the node --inspect-brk -e case.

PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

test: update postmortem metadata test
This commit updates the following postmortem metadata constant:

- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
  - Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
  - V8 commit: v8/v8@53d4dfc

PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

test: add new_large_object_space heap space
v8.getHeapSpaceStatistics() now includes new_large_object_space
in its results. Update test-v8-stats.js to account for this.

Refs: v8/v8@a383aa3

PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

test: update postmortem metadata test for V8 6.9
The V8 6.9 update requires the following adjustments to the
postmortem debugging metadata constants:

- v8dbg_class_SharedFunctionInfo__function_identifier__Object
  Use: v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object

- v8dbg_class_SharedFunctionInfo__end_position__int
  Use: v8dbg_class_UncompiledData__end_position__int32_t

- v8dbg_class_SharedFunctionInfo__start_position_and_type__int
  Use: v8dbg_class_UncompiledData__start_position__int32_t

- v8dbg_sharedfunctioninfo_start_position_mask and
- v8dbg_sharedfunctioninfo_start_position_shift
  Removed. Use: v8dbg_class_UncompiledData__start_position__int32_t

- v8dbg_scopeinfo_idx_nstacklocals has been removed

Refs: v8/v8@39e2d97
Refs: v8/v8@467eb14
Refs: v8/v8@c51bcd1

PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added a commit to targos/node that referenced this pull request Sep 7, 2018

src: update postmortem constant name
This commit renames
V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER__OBJECT to
V8DBG_CLASS_SHAREDFUNCTIONINFO__FUNCTION_IDENTIFIER_OR_DEBUG_INFO__OBJECT
following an upstream V8 change.

PR-URL: nodejs#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2018

Thank you Matteo!

Landed in 12ed7c9...dbf7203

@targos targos closed this Sep 7, 2018

@targos targos deleted the targos:v8-6.9 branch Sep 7, 2018

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

@targos Do we want to investigate backporting to Node 10? This comes with semver-major changes on Node’s side as well, forced by V8 changes, so it would definitely be tricky.

deepak1556 added a commit to electron/node that referenced this pull request Oct 5, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MarshallOfSound added a commit to electron/node that referenced this pull request Oct 25, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

MarshallOfSound added a commit to electron/node that referenced this pull request Oct 25, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

deepak1556 added a commit to electron/node that referenced this pull request Dec 10, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

deepak1556 added a commit to electron/node that referenced this pull request Dec 11, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

deepak1556 added a commit to electron/node that referenced this pull request Dec 19, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

deepak1556 added a commit to electron/node that referenced this pull request Dec 19, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

deepak1556 added a commit to electron/node that referenced this pull request Dec 19, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

deepak1556 added a commit to electron/node that referenced this pull request Dec 25, 2018

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nornagon added a commit to electron/node that referenced this pull request Feb 27, 2019

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nitsakh added a commit to electron/node that referenced this pull request Mar 1, 2019

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nitsakh added a commit to electron/node that referenced this pull request Mar 18, 2019

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nitsakh added a commit to electron/node that referenced this pull request Mar 18, 2019

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nitsakh added a commit to electron/node that referenced this pull request Mar 18, 2019

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

codebytere added a commit to electron/node that referenced this pull request Mar 20, 2019

src: initialize PerIsolateData eagerly
PR-URL: nodejs/node#21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.