Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to nghttp2 1.33.0 #22649

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
7 participants
@addaleax
Copy link
Member

commented Sep 2, 2018

Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax added the http2 label Sep 2, 2018

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2018

@targos

This comment has been minimized.

Copy link
Member

commented Sep 2, 2018

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2018

@cjihrig

cjihrig approved these changes Sep 2, 2018

Copy link
Contributor

left a comment

LGTM with a question.

@@ -29,14 +29,14 @@
* @macro
* Version number of the nghttp2 library release
*/
#define NGHTTP2_VERSION "1.32.0"
#define NGHTTP2_VERSION "1.33.0-DEV"

This comment has been minimized.

Copy link
@cjihrig

cjihrig Sep 2, 2018

Contributor

Should we be moving to a dev version? Or is this maybe a mistake on their end (based on the linked GitHub release)?

This comment has been minimized.

Copy link
@addaleax

addaleax Sep 2, 2018

Author Member

I think this is a mistake by me, not having run configure in the nghttp2 checkout before copying the files. Thanks for catching!

@mcollina
Copy link
Member

left a comment

Rubberstamp LGTM

@trivikr

trivikr approved these changes Sep 4, 2018

Copy link
Contributor

left a comment

RSLGTM

@danbev

This comment has been minimized.

Copy link
Member

commented Sep 5, 2018

Landed in e007166.

@danbev danbev closed this Sep 5, 2018

danbev added a commit that referenced this pull request Sep 5, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos added a commit that referenced this pull request Sep 5, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos added a commit that referenced this pull request Sep 5, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@targos targos referenced this pull request Sep 5, 2018

Merged

Release proposal: v10.10.0 #22716

targos added a commit that referenced this pull request Sep 6, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Sep 27, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 2, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Oct 3, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Oct 3, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Oct 4, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

kjin added a commit to kjin/node that referenced this pull request Oct 16, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

BethGriggs added a commit to BethGriggs/node that referenced this pull request Oct 16, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

Backport-PR-URL: nodejs#22850
PR-URL: nodejs#22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

BethGriggs added a commit that referenced this pull request Oct 17, 2018

deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

Backport-PR-URL: #22850
PR-URL: #22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@BethGriggs BethGriggs referenced this pull request Oct 30, 2018

Merged

v8.13.0 proposal #23974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.