Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
child_process: use non-infinite maxBuffer defaults #23027
I fixed the default behavior of
We discussed this PR and my idea was changed.
Is this what you talk about this?
I checked some history.
I think that this PR was unfit for spawnSync. Is it correct?
I agree that this is
Personally, I think it would make more sense to land #22894 first, because it corrects the docs, and adds tests for the current behaviour, tests that look to be substantially similar to the tests you are adding in this PR. #22894 change can be backported to 11.x (and further, as required - it would be helpful if you could make clear how far back the change should be backported).
Once its landed, since it added lots of tests (thanks!), I would then rebase this PR, the one that makes the code behave as it should (and as it used to be documented) onto master after #22894. It looks to me like it would keep much of the tests from #22894, but just change them to check different defaults. As a
Btw, could you (or whoever lands this) please update the commit description and message to be more informative and grammatical? I would suggest something like:
@koh110 with respect to
I think a follow-up PR to change the defaults for all the maxBuffer sizes to a much larger value would be well received, if you have the energy.