Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove public API for option variables #23069

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@addaleax
Copy link
Member

commented Sep 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@devsnek
Copy link
Member

left a comment

🎉

@Leko

Leko approved these changes Sep 25, 2018

@refack

refack approved these changes Sep 25, 2018

Copy link
Member

left a comment

🎉

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2018

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2018

Landed in cc31d8b

@addaleax addaleax closed this Oct 3, 2018

@addaleax addaleax deleted the addaleax:remove-deprecated-variables branch Oct 3, 2018

addaleax added a commit that referenced this pull request Oct 3, 2018

src: remove public API for option variables
PR-URL: #23069
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

jasnell added a commit that referenced this pull request Oct 17, 2018

src: remove public API for option variables
PR-URL: #23069
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.