Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: error when empty buffer is passed to fs.read() #23141

Closed
wants to merge 1 commit into from

Conversation

Projects
9 participants
@shisama
Copy link
Contributor

commented Sep 28, 2018

Added tests to occur error when empty buffer is passed to fs.read()
to increase coverage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca

lpinca approved these changes Sep 28, 2018

test: error when empty buffer is passed to fs.read()
Added tests to occur error when empty buffer is passed to fs.read()
to increase coverage.

@shisama shisama force-pushed the shisama:test-fs-read-empty-buffer branch from 64168b8 to 3bf28b1 Sep 30, 2018

@danbev

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 1, 2018

@shisama

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2018

@danbev @addaleax Thank you to run CI. However, it failed. I think the failure is caused by flaky test (#23067).

@danbev

This comment has been minimized.

Copy link
Member

commented Oct 2, 2018

@danbev

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

Landed in 097896b.

@danbev danbev closed this Oct 3, 2018

danbev added a commit that referenced this pull request Oct 3, 2018

test: error when empty buffer is passed to fs.read()
Added tests to occur error when empty buffer is passed to fs.read()
to increase coverage.

PR-URL: #23141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@targos targos added this to Don't land (ever) in v10.x Oct 6, 2018

jasnell added a commit that referenced this pull request Oct 17, 2018

test: error when empty buffer is passed to fs.read()
Added tests to occur error when empty buffer is passed to fs.read()
to increase coverage.

PR-URL: #23141
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.