Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove some useless assignments #23199

Closed
wants to merge 1 commit into from

Conversation

@devsnek
Copy link
Member

commented Oct 1, 2018

cc @indutny

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig
cjihrig approved these changes Oct 1, 2018
@@ -1081,10 +1081,6 @@ function afterConnect(status, handle, req, readable, writable) {
return;
}

// Update handle if it was wrapped
// TODO(indutny): assert that the handle is actually an ancestor of old one

This comment has been minimized.

Copy link
@mscdex

mscdex Oct 1, 2018

Contributor

Should this TODO be removed?

This comment has been minimized.

Copy link
@devsnek

devsnek Oct 1, 2018

Author Member

that's why I pinged @indutny

This comment has been minimized.

Copy link
@indutny

indutny Oct 11, 2018

Member

I'm afraid I no longer remember what this was about. This comments is years old.

This comment has been minimized.

Copy link
@thefourtheye

thefourtheye Oct 11, 2018

Contributor

Perhaps this particular change alone can be done in a separate PR then?

@addaleax

This comment has been minimized.

@danbev

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

Re-run of failing node-test-commit-arm ✔️

@devsnek devsnek removed the author ready label Oct 5, 2018

@devsnek

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2018

this can't land until @indutny confirms the removal of that line

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

Given that @indutny isn't sure what the line refers to, I think it's acceptable to remove it as no one else is likely to know either.

Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2018
lib: remove some useless assignments
PR-URL: nodejs#23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

Landed in 366aaf5

@Trott Trott closed this Dec 5, 2018

BridgeAR added a commit that referenced this pull request Dec 6, 2018
lib: remove some useless assignments
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Dec 6, 2018
4 of 4 tasks complete
BridgeAR added a commit that referenced this pull request Dec 7, 2018
lib: remove some useless assignments
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
lib: remove some useless assignments
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
lib: remove some useless assignments
PR-URL: nodejs#23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
lib: remove some useless assignments
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 20, 2019
lib: remove some useless assignments
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rvagg added a commit that referenced this pull request Feb 28, 2019
lib: remove some useless assignments
PR-URL: #23199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.