Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove some useless assignments #23199

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -220,7 +220,7 @@ function _addListener(target, type, listener, prepend) {

if (existing === undefined) {
// Optimize the case of one listener. Don't need the extra array object.
existing = events[type] = listener;
events[type] = listener;
++target._eventsCount;
} else {
if (typeof existing === 'function') {
@@ -258,7 +258,7 @@ function* emitKeys(stream) {
s += (ch = yield);

if (ch >= '0' && ch <= '9') {
s += (ch = yield);
s += yield;
}
}

@@ -1081,10 +1081,6 @@ function afterConnect(status, handle, req, readable, writable) {
return;
}

// Update handle if it was wrapped
// TODO(indutny): assert that the handle is actually an ancestor of old one

This comment has been minimized.

Copy link
@mscdex

mscdex Oct 1, 2018

Contributor

Should this TODO be removed?

This comment has been minimized.

Copy link
@devsnek

devsnek Oct 1, 2018

Author Member

that's why I pinged @indutny

This comment has been minimized.

Copy link
@indutny

indutny Oct 11, 2018

Member

I'm afraid I no longer remember what this was about. This comments is years old.

This comment has been minimized.

Copy link
@thefourtheye

thefourtheye Oct 11, 2018

Contributor

Perhaps this particular change alone can be done in a separate PR then?

handle = self._handle;

debug('afterConnect');

assert(self.connecting);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.