New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: remove node::crypto::CheckResult #23225

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@tniessen
Member

tniessen commented Oct 2, 2018

This enum and its constants are unused within the codebase.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@cjihrig

cjihrig approved these changes Oct 2, 2018

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Oct 2, 2018

Member

Seems like it was added in 3beb880 and then became unused when VerifyCallback was changed to always return 1.

Member

tniessen commented Oct 2, 2018

Seems like it was added in 3beb880 and then became unused when VerifyCallback was changed to always return 1.

@jasnell

jasnell approved these changes Oct 2, 2018

@refack

refack approved these changes Oct 2, 2018

@tniessen

This comment has been minimized.

Show comment
Hide comment
@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Oct 8, 2018

Member

Landed in 1c75ec2.

Member

danbev commented Oct 8, 2018

Landed in 1c75ec2.

@danbev danbev closed this Oct 8, 2018

danbev added a commit that referenced this pull request Oct 8, 2018

crypto: remove node::crypto::CheckResult
PR-URL: #23225
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

targos added a commit that referenced this pull request Oct 10, 2018

crypto: remove node::crypto::CheckResult
PR-URL: #23225
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

sagitsofan added a commit to sagitsofan/node that referenced this pull request Oct 10, 2018

crypto: remove node::crypto::CheckResult
PR-URL: nodejs#23225
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

jasnell added a commit that referenced this pull request Oct 17, 2018

crypto: remove node::crypto::CheckResult
PR-URL: #23225
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment