http: remove duplicate async_hooks init for http parser #23263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
basti1302
commented
Oct 4, 2018
| triggerAsyncId: 'tcp:2' }, | ||
| { type: 'Timeout', | ||
| id: 'timeout:2', | ||
| triggerAsyncId: 'httpparser:4' }, | ||
| triggerAsyncId: 'httpparser:2' }, | ||
| { type: 'SHUTDOWNWRAP', | ||
| id: 'shutdown:1', | ||
| triggerAsyncId: 'tcp:2' } ] |
There was a problem hiding this comment.
This very much looks like the output of verify-graph#printGraph has simply been copied here without giving it much thought. The duplicated HTTPPARSER init calls were showing here and don't make much sense, IMO.
basti1302
commented
Oct 4, 2018
| @@ -8,24 +8,23 @@ const FreeList = require('internal/freelist'); | |||
|
|
|||
| assert.strictEqual(typeof FreeList, 'function'); | |||
|
|
|||
| const flist1 = new FreeList('flist1', 3, String); | |||
| const flist1 = new FreeList('flist1', 3, Object); | |||
There was a problem hiding this comment.
One downside of this change is that the items in freelist can no longer be primitives, since we attach an attribute to it. But as the freelist is only used for HTTP parsers anyway, I don't think it is an issue.
3 tasks
|
cc @nodejs/http @nodejs/async_hooks |
basti1302
force-pushed
the
fix-missing-async-hooks-destroy-http-parser
branch
2 times, most recently
from
db9426d
to
0ba5ae7
Compare
ofrobots
reviewed
Oct 4, 2018
lib/internal/freelist.js
Outdated
| @@ -23,4 +23,14 @@ class FreeList { | |||
| } | |||
| } | |||
|
|
|||
| function needsToCallAsyncReset(item) { | |||
| item.needsAsyncReset = true; | |||
basti1302
force-pushed
the
fix-missing-async-hooks-destroy-http-parser
branch
2 times, most recently
from
e27f470
to
d35be44
Compare
Each time a new parser was created, AsyncReset was being called via the C++ Parser class constructor (super constructor AsyncWrap) and also via Parser::Reinitialize. This also adds a missing async_hooks destroy event before AsyncReset is called for the parser reuse case, otherwise the old async_id never gets destroyed. Refs: nodejs#19859
This also at least keeps up the appearance of FreeList being a generic all purpose thing (right now it is only used for HTTP parsers but theoretically it could be used for any reusable resource). The previous name "needsAsyncReset" implied a tight coupling to to async resources, the new name "is_reused" is more generic.
basti1302
force-pushed
the
fix-missing-async-hooks-destroy-http-parser
branch
from
0c081fc
to
26d1471
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time a new parser was created, AsyncReset was being called via
the C++ Parser class constructor (super constructor AsyncWrap) and also
via Parser::Reinitialize.
This also adds a missing async_hooks destroy event before AsyncReset is
called for the parser reuse case, otherwise the old async_id never gets
destroyed.
Refs: #19859
See also: #23201
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes(https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)
I was not yet able to write a decent test case for that, but the changes to test/async-hooks/test-graph.http.js already prove that the duplicated init hook call (which was actually tested for there) has been removed. I see what I can do about adding a more explicit test.Update: There is a test now but it only works when I restrict it to theinithooks called in the http client context. Without this restriction, there are stillinitcalls without a matching destroy so I suspect there is still in issue when using parsers in http server.Update 2: I was able to remove the restriction on _http_client
initcalls, it was a test issue after all.