Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: refactor zlib internals #23360

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Oct 10, 2018

  • zlib: generate error code names in C++

    This makes it easier to implement the lookup in a way that targets
    error codes from a specific compression library, as a way towards
    supporting multiple ones (e.g. brotli).

  • zlib: refactor zlib internals

    Split out things that are specific to zlib as a specific
    compression library, vs. the interface that is common to
    most C compression libraries.

    This should pave the way for including support for e.g.
    brotli.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax force-pushed the addaleax:zlib-refactor branch from 9d11e19 to b8567e7 Oct 10, 2018

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2018

Fixed the compiler error from linux-one.

CI: https://ci.nodejs.org/job/node-test-pull-request/17713/ (✔️)

@addaleax addaleax referenced this pull request Oct 10, 2018
2 of 2 tasks complete
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2018

This should not affect runtime performance, but here’s a benchmark CI just to be super sure:

CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/242/

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2018

Infra failure in the benchmarks build… new run (again, just to be extra sure): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/244/

creation.js benchmark with more iterations: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/246/ (✔️)

zlib: refactor zlib internals
Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

@addaleax addaleax force-pushed the addaleax:zlib-refactor branch from b8567e7 to 4b9ba67 Oct 12, 2018

@danbev
danbev approved these changes Oct 16, 2018
@danbev

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

Landed in c34eae5.

@danbev danbev closed this Oct 16, 2018

danbev added a commit that referenced this pull request Oct 16, 2018
zlib: refactor zlib internals
Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: #23360
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
burgerboydaddy added a commit to burgerboydaddy/node that referenced this pull request Oct 17, 2018
zlib: refactor zlib internals
Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: nodejs#23360
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request Oct 17, 2018
zlib: refactor zlib internals
Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: #23360
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@addaleax addaleax deleted the addaleax:zlib-refactor branch Oct 17, 2018

@addaleax addaleax referenced this pull request Oct 17, 2018
4 of 4 tasks complete
addaleax added a commit that referenced this pull request Oct 20, 2018
zlib: refactor zlib internals
Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: #23360
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 30, 2018
zlib: refactor zlib internals
Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: #23360
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
zlib: refactor zlib internals
Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: #23360
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
zlib: refactor zlib internals
Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: #23360
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.