Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 7.1 #23423

Closed
wants to merge 11 commits into from

Conversation

Projects
None yet
@targos
Copy link
Member

commented Oct 11, 2018

ETA: Dec 4th, 2018

@targos targos added the blocked label Oct 11, 2018

@refack

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

IHMO we should land this after the release of node11. Having the V8 dev branch checked-in and distributed via nightlies can surface issues earlier.
Ref: #23122

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

IHMO we should land this after the release of node11.

Not sure if I’m understanding correctly, but the ETA date in the PR description is in December.

@targos targos force-pushed the targos:v8-7.1 branch from 028bf4b to 47f4af7 Oct 11, 2018

@richardlau

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

Having the V8 dev branch checked-in and distributed via nightlies can surface issues earlier.
Ref: #23122

I thought that was the point of the canary builds.

@refack

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

IHMO we should land this after the release of node11.

Not sure if I’m understanding correctly, but the ETA date in the PR description is in December.

AFAIU the ETA is for the 7.1 branch to go stable.
The 7.1 branch was just released as "dev" - https://www.chromium.org/developers/calendar / https://www.chromestatus.com/features/schedule

Bottom line, I'm suggesting considering changing our V8 policy, to push the timeline forward one milestone. That is bump V8 version when it goes beta, so we could give better feedback to V8.

@targos targos force-pushed the targos:v8-7.1 branch from 47f4af7 to f9b6c7f Oct 16, 2018

@targos

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2018

Temporarily added v8/v8@9820083. I'll open a merge request for it upstream.

@refack

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

ppcle-ubuntu1404 fail (something about no atspi-2) - https://ci.nodejs.org/job/node-test-commit-v8-linux/1764/nodes=ppcle-ubuntu1404,v8test=v8test/console

16:21:50 ERROR at //build/config/linux/pkg_config.gni:103:17: Script returned non-zero exit code.
16:21:50     pkgresult = exec_script(pkg_config_script, args, "value")
16:21:50                 ^----------
16:21:50 Current dir: /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/out.gn/ppc64.release/
16:21:50 Command: python -- /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcle-ubuntu1404/v8test/v8test/deps/v8/build/config/linux/pkg-config.py atspi-2
16:21:50 Returned 1.
16:21:50 stderr:
16:21:50 
16:21:50 Package atspi-2 was not found in the pkg-config search path.
16:21:50 Perhaps you should add the directory containing `atspi-2.pc'
16:21:50 to the PKG_CONFIG_PATH environment variable
16:21:50 No package 'atspi-2' found
16:21:50 Could not run pkg-config.
16:21:50 
16:21:50 See //build/config/linux/BUILD.gn:104:3: whence it was called.
16:21:50   pkg_config("atspi2") {
16:21:50   ^---------------------
16:21:50 See //build/config/compiler/BUILD.gn:224:18: which caused the file to be included.
16:21:50     configs += [ "//build/config/linux:compiler" ]
16:21:50                  ^------------------------------
16:21:50 ninja: Entering directory `out.gn/ppc64.release'
16:21:50 ninja: error: loading 'build.ninja': No such file or directory
@refack

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

Same on rhel72-s390x - https://ci.nodejs.org/job/node-test-commit-v8-linux/1764/nodes=rhel72-s390x,v8test=v8test

16:21:15 ERROR at //build/config/linux/pkg_config.gni:103:17: Script returned non-zero exit code.
16:21:15     pkgresult = exec_script(pkg_config_script, args, "value")
16:21:15                 ^----------
16:21:15 Current dir: /data/iojs/build/workspace/node-test-commit-v8-linux/nodes/rhel72-s390x/v8test/v8test/deps/v8/out.gn/s390x.release/
16:21:15 Command: python -- /data/iojs/build/workspace/node-test-commit-v8-linux/nodes/rhel72-s390x/v8test/v8test/deps/v8/build/config/linux/pkg-config.py atspi-2
16:21:15 Returned 1.
16:21:15 stderr:
16:21:15 
16:21:15 Package atspi-2 was not found in the pkg-config search path.
16:21:15 Perhaps you should add the directory containing `atspi-2.pc'
16:21:15 to the PKG_CONFIG_PATH environment variable
16:21:15 No package 'atspi-2' found
16:21:15 Could not run pkg-config.
16:21:15 
16:21:15 See //build/config/linux/BUILD.gn:104:3: whence it was called.
16:21:15   pkg_config("atspi2") {
16:21:15   ^---------------------
16:21:15 See //build/config/compiler/BUILD.gn:224:18: which caused the file to be included.
16:21:15     configs += [ "//build/config/linux:compiler" ]
16:21:15                  ^------------------------------
16:21:15 ninja: Entering directory `out.gn/s390x.release'
16:21:15 ninja: error: loading 'build.ninja': No such file or directory

@refack refack added the ppc label Oct 16, 2018

@refack

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@mhdawson

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@john-yan Please investigate

@john-yan

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2018

This doesn't seem to be a issue on my environment.

root@1b204ecb20c7:/workdir/v8/v8# pkg-config --cflags atspi-2
-I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/s390x-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/s390x-linux-gnu/glib-2.0/include

Could you please install the required packages?

@mhdawson

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@john-yan what do you mean by install the required packages? If these are OS level packages then it is the ansible scripts for the build machines we'd have to update (In this case either they are already updated for other linuxes or are installed by default for x86 but not ppc and s390). @gdams can you take a look to see there is a delta between what is installed for x86 and power/s390?

@john-yan

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2018

I mean installing atspi-2 on the OS

@mhdawson

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@gdams based on the response from @john-yan is to look at why it would be installed already on x86 but not PPC and s390 platforms.

@refack

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@gdams based on the response from @john-yan is to look at why it would be installed already on x86 but not PPC and s390 platforms.

@mhdawson do we have a channel to V8 to get informed of CI requirements changes (this is not the first, second, or third time we are caught by surprise). A simple email or issue in time could save our limited resources a significant amount of time.

@targos

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2018

CI is green but we have 286f55c

@refack IIRC you told me that relanding #23257 would fix the issue. What can we do about the problem that happened with macOS?

@refack

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

The issue that 286f55c solves is now reproducing on most platforms.
We should open a PR to land it in master (it's not a bad solution on it's own)

@targos

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2018

I'd really like to reland #23257 or something else that fixes gyp.

Look at everything that a simple make does when everything is already built (and make test does it 5 times before starting js tests):

$ make
make -C out BUILDTYPE=Release V=1
  touch 7deef87658560b6cb960e9242115dd3d413db222.intermediate
  LD_LIBRARY_PATH=/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.host:/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/gypfiles; mkdir -p /home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/torque-generated; "/home/mzasso/git/nodejs/v8-7.1/out/Release/torque" ../src/builtins/base.tq ../src/builtins/array.tq ../src/builtins/array-copywithin.tq ../src/builtins/array-foreach.tq ../src/builtins/array-lastindexof.tq ../src/builtins/array-reverse.tq ../src/builtins/array-splice.tq ../src/builtins/array-unshift.tq ../src/builtins/typed-array.tq ../src/builtins/data-view.tq ../test/torque/test-torque.tq ../third_party/v8/builtins/array-sort.tq -o "/home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/torque-generated"
  LD_LIBRARY_PATH=/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.host:/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/gypfiles; mkdir -p /home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/src; python ../third_party/inspector_protocol/CheckProtocolCompatibility.py --stamp "/home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/src/js_protocol.stamp" ../src/inspector/js_protocol.json
  touch 55cc9c5933807eca67a46418e8d8977b967029a6.intermediate
  LD_LIBRARY_PATH=/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.host:/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/gypfiles; mkdir -p /home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/src/inspector/protocol /home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/include/inspector; python ../third_party/inspector_protocol/CodeGenerator.py --jinja_dir ../third_party --output_base "/home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/src/inspector" --config ../src/inspector/inspector_protocol_config.json
  touch 389de90135f8f3d665947de4342131060def7393.intermediate
  LD_LIBRARY_PATH=/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.host:/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/gypfiles; mkdir -p /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni; "/home/mzasso/git/nodejs/v8-7.1/out/Release/mksnapshot" --turbo_instruction_scheduling --embedded_src "/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/embedded.cc" --embedded_variant Default --startup_src "/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/snapshot.cc"
  g++ -o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/embedded.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/embedded.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.1"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DV8_EMBEDDED_BUILTINS' '-DV8_EMBEDDED_BYTECODE_HANDLERS' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /home/mzasso/git/nodejs/v8-7.1/out/Release/.deps//home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/embedded.o.d.raw   -c
  g++ -o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/snapshot.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/snapshot.cc '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.1"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' '-DV8_EMBEDDED_BUILTINS' '-DV8_EMBEDDED_BYTECODE_HANDLERS' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../. -I/home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /home/mzasso/git/nodejs/v8-7.1/out/Release/.deps//home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/snapshot.o.d.raw   -c
In file included from ../deps/v8/src/address-map.h:8,
                 from ../deps/v8/src/snapshot/partial-serializer.h:8,
                 from ../deps/v8/src/snapshot/snapshot.h:8,
                 from /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/snapshot.cc:6:
../deps/v8/include/v8.h: In member function ‘virtual bool v8::String::ExternalStringResourceBase::IsCacheable() const’:
../deps/v8/include/v8.h:2649:30: warning: ‘virtual bool v8::String::ExternalStringResourceBase::IsCompressible() const’ is deprecated: Use IsCacheable(). [-Wdeprecated-declarations]
       return !IsCompressible();
                              ^
In file included from ../deps/v8/include/v8-internal.h:13,
                 from ../deps/v8/src/globals.h:14,
                 from ../deps/v8/src/v8.h:8,
                 from /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/snapshot.cc:3:
../deps/v8/include/v8.h:2635:36: note: declared here
                       virtual bool IsCompressible() const) {
                                    ^~~~~~~~~~~~~~
../deps/v8/include/v8config.h:341:3: note: in definition of macro ‘V8_DEPRECATE_SOON’
   declarator __attribute__((deprecated(message)))
   ^~~~~~~~~~
  rm -f /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_snapshot.a && ar crsT /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_snapshot.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/gen/experimental-extras-libraries.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/gen/extras-libraries.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/gen/libraries.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/deps/v8/src/setup-isolate-deserialize.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/embedded.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/v8_snapshot/geni/snapshot.o
  touch /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/v8_maybe_snapshot.stamp
  touch /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/v8.stamp
  touch 1270726b04c0aa2ea7dad5b119c7fdafdb724f61.intermediate
  LD_LIBRARY_PATH=/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.host:/home/mzasso/git/nodejs/v8-7.1/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/src/node/inspector/protocol; python tools/inspector_protocol/CodeGenerator.py --jinja_dir tools/inspector_protocol/.. --output_base "/home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/src/" --config "/home/mzasso/git/nodejs/v8-7.1/out/Release/obj/gen/node_protocol_config.json"
  g++ -o /home/mzasso/git/nodejs/v8-7.1/out/Release/node -pthread -rdynamic -m64 -Wl,--whole-archive,/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/libnode.a -Wl,--no-whole-archive -Wl,--whole-archive,/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/zlib/libzlib.a -Wl,--no-whole-archive -Wl,--whole-archive,/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/uv/libuv.a -Wl,--no-whole-archive -Wl,-z,noexecstack -Wl,--whole-archive /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_base.a -Wl,--no-whole-archive -Wl,-z,relro -Wl,-z,now -Wl,--whole-archive,/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/openssl/libopenssl.a -Wl,--no-whole-archive -pthread  -Wl,--start-group /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/node/src/node_main.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/libnode.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_libplatform.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/tools/icu/libicui18n.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/zlib/libzlib.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/http_parser/libhttp_parser.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/cares/libcares.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/uv/libuv.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/nghttp2/libnghttp2.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/openssl/libopenssl.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_base.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_libbase.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_libsampler.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/tools/icu/libicuucx.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/tools/icu/libicudata.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/tools/icu/libicustubdata.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_snapshot.a -ldl -lrt -lm -Wl,--end-group
  touch /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/rename_node_bin_win.stamp
  g++ -o /home/mzasso/git/nodejs/v8-7.1/out/Release/cctest -pthread -rdynamic -m64 -Wl,--whole-archive,/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/zlib/libzlib.a -Wl,--no-whole-archive -Wl,--whole-archive,/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/uv/libuv.a -Wl,--no-whole-archive -Wl,-z,noexecstack -Wl,--whole-archive /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_base.a -Wl,--no-whole-archive -Wl,-z,relro -Wl,-z,now -Wl,--whole-archive,/home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/openssl/libopenssl.a -Wl,--no-whole-archive -pthread  -Wl,--start-group /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/node_test_fixture.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_aliased_buffer.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_base64.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_node_postmortem_metadata.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_environment.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_platform.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_traced_value.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_util.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_url.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_inspector_socket.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/cctest/test/cctest/test_inspector_socket_server.o /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/libnode.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/gtest/libgtest.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_libplatform.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/tools/icu/libicui18n.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/zlib/libzlib.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/http_parser/libhttp_parser.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/cares/libcares.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/uv/libuv.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/nghttp2/libnghttp2.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/openssl/libopenssl.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_base.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_libbase.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_libsampler.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/tools/icu/libicuucx.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/tools/icu/libicudata.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/tools/icu/libicustubdata.a /home/mzasso/git/nodejs/v8-7.1/out/Release/obj.target/deps/v8/gypfiles/libv8_snapshot.a -ldl -lrt -lm -Wl,--end-group
rm 389de90135f8f3d665947de4342131060def7393.intermediate 1270726b04c0aa2ea7dad5b119c7fdafdb724f61.intermediate 7deef87658560b6cb960e9242115dd3d413db222.intermediate 55cc9c5933807eca67a46418e8d8977b967029a6.intermediate
if [ ! -r node -o ! -L node ]; then ln -fs out/Release/node node; fi
@refack

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

I'd really like to reland #23257 or something else that fixes gyp.

Yeah... I think I found a hidden cyclic dependency in the makefiles. It only shows up when there's no rebuild

(I could also put an if OS=='osx' into #23257...)

@mhdawson

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

@targos you mean the Node CI is green as opposed to the v8 one?

@targos

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2018

@mhdawson yes

@targos targos closed this Dec 6, 2018

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 6, 2018

deps: update V8 to 7.1.302.28
PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 6, 2018

build: reset embedder string to "-node.0"
PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 6, 2018

src: update NODE_MODULE_VERSION to 68
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 7.1.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 6, 2018

deps: sync V8 gypfiles with 7.1
Enable v8_enable_embedded_builtins.
Reorder conditions proccessing for `run_mksnapshot`.

deps,v8: link with `atomic` for platforms lacking CAS
Fixes: nodejs/node-v8#81

Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 6, 2018

test: update postmortem metadata test for V8 7.1
The V8 7.1 update requires the following adjustments to the
postmortem debugging metadata constants:

- v8dbg_class_JSArrayBuffer__byte_length__Object
  Use: v8dbg_class_JSArrayBuffer__byte_length__size_t

- v8dbg_class_JSArrayBufferView__raw_byte_length__Object
  Use: v8dbg_class_JSArrayBufferView__byte_length__size_t

- v8dbg_class_JSArrayBufferView__raw_byte_offset__Object
  Use: v8dbg_class_JSArrayBufferView__byte_offset__size_t

- v8dbg_class_String__length__SMI
  Use: v8dbg_class_String__length__int32_t

Refs: v8/v8@5cfe1a6
Refs: v8/v8@c7a0049

PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 6, 2018

src: update postmortem constant
Update a postmortem constant used by the ustack helper which
changed while moving to V8 7.1.

PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Dec 6, 2018

src: explicitly allow JS in ReadHostObject
PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

deps: update V8 to 7.1.302.28
PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

build: reset embedder string to "-node.0"
PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: update NODE_MODULE_VERSION to 68
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 7.1.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

deps: sync V8 gypfiles with 7.1
Enable v8_enable_embedded_builtins.
Reorder conditions proccessing for `run_mksnapshot`.

deps,v8: link with `atomic` for platforms lacking CAS
Fixes: nodejs/node-v8#81

Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

test: update postmortem metadata test for V8 7.1
The V8 7.1 update requires the following adjustments to the
postmortem debugging metadata constants:

- v8dbg_class_JSArrayBuffer__byte_length__Object
  Use: v8dbg_class_JSArrayBuffer__byte_length__size_t

- v8dbg_class_JSArrayBufferView__raw_byte_length__Object
  Use: v8dbg_class_JSArrayBufferView__byte_length__size_t

- v8dbg_class_JSArrayBufferView__raw_byte_offset__Object
  Use: v8dbg_class_JSArrayBufferView__byte_offset__size_t

- v8dbg_class_String__length__SMI
  Use: v8dbg_class_String__length__int32_t

Refs: v8/v8@5cfe1a6
Refs: v8/v8@c7a0049

PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: update postmortem constant
Update a postmortem constant used by the ustack helper which
changed while moving to V8 7.1.

PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

src: explicitly allow JS in ReadHostObject
PR-URL: nodejs#23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@BethGriggs BethGriggs referenced this pull request Mar 26, 2019

Merged

v12.0.0 proposal #26930

BethGriggs added a commit that referenced this pull request Apr 22, 2019

2019-04-23, Version 12.0.0 (Current)
Notable changes:

* assert:
  * improve performance to instantiate errors (Ruben Bridgewater)
    [#26738](#26738)
  * validate required arguments (Ruben Bridgewater)
    [#26641](#26641)
  * adjust loose assertions (Ruben Bridgewater)
    [#25008](#25008)
* async_hooks:
  * remove deprecated emitBefore and emitAfter (Matteo Collina)
    [#26530](#26530)
  * remove promise object from resource (Andreas Madsen)
    [#23443](#23443)
* bootstrap
  * make Buffer and process non-enumerable (Ruben Bridgewater)
    [#24874](#24874)
* buffer:
  * use stricter range checks (Ruben Bridgewater)
    [#27045](#27045)
  * harden SlowBuffer creation (ZYSzys)
    [#26272](#26272)
  * harden validation of buffer allocation size (ZYSzys)
    [#26162](#26162)
  * do proper error propagation in addon methods (Anna Henningsen)
    [#23939](#23939)
* child_process:
  * change the defaults maxBuffer size (kohta ito)
    [#27179](#27179)
  * harden fork arguments validation (ZYSzys)
    [#27039](#27039)
  * use non-infinite maxBuffer defaults (kohta ito)
    [#23027](#23027)
* console:
  * don't use ANSI escape codes when TERM=dumb (Vladislav Kaminsky)
    [#26261](#26261)
* crypto:
  * remove legacy native handles (Tobias Nießen)
    [#27011](#27011)
  * decode missing passphrase errors (Tobias Nießen)
    [#25208](#25208)
  * move DEP0113 to End-of-Life (Tobias Nießen)
    [#26249](#26249)
  * remove deprecated crypto.\_toBuf (Tobias Nießen)
    [#25338](#25338)
  * set `DEFAULT\_ENCODING` property to non-enumerable
    (Antoine du Hamel)
    [#23222](#23222)
* deps:
  * silence irrelevant V8 warning (Michaël Zasso)
    [#26685](#26685)
  * update postmortem metadata generation script (cjihrig)
    [#26685](#26685)
  * V8: un-cherry-pick bd019bd (Refael Ackermann)
    [#26685](#26685)
  * V8: cherry-pick 6 commits (Michaël Zasso)
    [#26685](#26685)
  * V8: cherry-pick d82c9af (Anna Henningsen)
    [#26685](#26685)
  * V8: cherry-pick e5f01ba (Anna Henningsen)
    [#26685](#26685)
  * V8: cherry-pick d5f08e4 (Anna Henningsen)
    [#26685](#26685)
  * V8: cherry-pick 6b09d21 (Anna Henningsen)
    [#26685](#26685)
  * V8: cherry-pick f0bb5d2 (Anna Henningsen)
    [#26685](#26685)
  * V8: cherry-pick 5b0510d (Anna Henningsen)
    [#26685](#26685)
  * V8: cherry-pick 91f0cd0 (Anna Henningsen)
    [#26685](#26685)
  * V8: cherry-pick 392316d (Anna Henningsen)
    [#26685](#26685)
  * V8: cherry-pick 2f79d68 (Anna Henningsen)
    [#26685](#26685)
  * sync V8 gypfiles with 7.4 (Ujjwal Sharma)
    [#26685](#26685)
  * update V8 to 7.4.288.13 (Ujjwal Sharma)
    [#26685](#26685)
  * bump minimum icu version to 63 (Ujjwal Sharma)
    [#25852](#25852)
  * silence irrelevant V8 warnings (Michaël Zasso)
    [#25852](#25852)
  * V8: cherry-pick 7803fa6 (Jon Kunkee)
    [#25852](#25852)
  * V8: cherry-pick 58cefed (Jon Kunkee)
    [#25852](#25852)
  * V8: cherry-pick d3308d0 (Michaël Zasso)
    [#25852](#25852)
  * V8: cherry-pick 74571c8 (Michaël Zasso)
    [#25852](#25852)
  * cherry-pick fc0ddf5 from upstream V8 (Anna Henningsen)
    [#25852](#25852)
  * sync V8 gypfiles with 7.3 (Ujjwal Sharma)
    [#25852](#25852)
  * sync V8 gypfiles with 7.2 (Michaël Zasso)
    [#25852](#25852)
  * update V8 to 7.3.492.25 (Michaël Zasso)
    [#25852](#25852)
  * add s390 asm rules for OpenSSL-1.1.1 (Shigeki Ohtsu)
    [#19794](#19794)
  * sync V8 gypfiles with 7.1 (Refael Ackermann)
    [#23423](#23423)
  * update V8 to 7.1.302.28 (Michaël Zasso)
    [#23423](#23423)
* doc:
  * update behaviour of fs.writeFile
    (Sakthipriyan Vairamani (thefourtheye))
    [#25080](#25080)
  * add internal functionality details of util.inherits
    (Ruben Bridgewater)
    [#24755](#24755)
* errors:
  * update error name (Ruben Bridgewater)
    [#26738](#26738)
* fs:
  * use proper .destroy() implementation for SyncWriteStream
    (Matteo Collina)
    [#26690](#26690)
  * improve mode validation (Ruben Bridgewater)
    [#26575](#26575)
  * harden validation of start option in createWriteStream (ZYSzys)
    [#25579](#25579)
  * make writeFile consistent with readFile wrt fd
    (Sakthipriyan Vairamani (thefourtheye))
    [#23709](#23709)
* http:
  * validate timeout in ClientRequest() (cjihrig)
    [#26214](#26214)
  * return HTTP 431 on HPE\_HEADER\_OVERFLOW error (Albert Still)
    [#25605](#25605)
  * switch default parser to llhttp (Anna Henningsen)
    [#24870](#24870)
  * change DEP0066 to a runtime deprecation (Morgan Roderick)
    [#24167](#24167)
  * else case is not reachable (szabolcsit)
    [#24176](#24176)
* lib:
  * move DEP0021 to end of life (cjihrig)
    [#27127](#27127)
  * remove Atomics.wake (Gus Caplan)
    [#27033](#27033)
  * validate Error.captureStackTrace() calls (Ruben Bridgewater)
    [#26738](#26738)
  * refactor Error.captureStackTrace() usage (Ruben Bridgewater)
    [#26738](#26738)
  * move DTRACE\_\* probes out of global scope (James M Snell)
    [#26541](#26541)
  * deprecate \_stream\_wrap (Sam Roberts)  [#26245]
  (#26245)
  * don't use `util.inspect()` internals (Ruben Bridgewater)
    [#24971](#24971)
  * improve error message for MODULE\_NOT\_FOUND (Ali Ijaz Sheikh)
    [#25690](#25690)
  * requireStack property for MODULE\_NOT\_FOUND (Ali Ijaz Sheikh)
    [#25690](#25690)
  * move DEP0029 to end of life (cjihrig)
    [#25377](#25377)
  * move DEP0028 to end of life (cjihrig)
    [#25377](#25377)
  * move DEP0027 to end of life (cjihrig)
    [#25377](#25377)
  * move DEP0026 to end of life (cjihrig)
    [#25377](#25377)
  * move DEP0023 to end of life (cjihrig)
    [#25280](#25280)
  * move DEP0006 to end of life (cjihrig)
    [#25279](#25279)
  * remove unintended access to deps/ (Anna Henningsen)
    [#25138](#25138)
  * move DEP0120 to end of life (cjihrig)
    [#24862](#24862)
  * use ES6 class inheritance style (Ruben Bridgewater)
    [#24755](#24755)
  * remove `inherits()` usage (Ruben Bridgewater)
    [#24755](#24755)
* module:
  * remove dead code (Ruben Bridgewater)
    [#26983](#26983)
  * mark DEP0019 as End-of-Life (Ruben Bridgewater)
    [#26973](#26973)
  * throw an error for invalid package.json main entries
    (Ruben Bridgewater)
    [#26823](#26823)
  * don't search in require.resolve.paths (cjihrig)
    [#23683](#23683)
* n-api:
  * remove code from error name (Ruben Bridgewater)
    [#26738](#26738)
* net:
  * do not manipulate potential user code (Ruben Bridgewater)
    [#26751](#26751)
  * emit "write after end" errors in the next tick (Ouyang Yadong)
    [#24457](#24457)
  * deprecate \_setSimultaneousAccepts() undocumented function
    (James M Snell)
    [#23760](#23760)
* net,http2:
  * merge setTimeout code (ZYSzys)
    [#25084](#25084)
* os:
  * implement os.type() using uv\_os\_uname() (cjihrig)
    [#25659](#25659)
* process:
  * global.process, global.Buffer getters (Guy Bedford)
    [#26882](#26882)
  * move DEP0062 (node --debug) to end-of-life (Joyee Cheung)
    [#25828](#25828)
  * exit on --debug and --debug-brk after option parsing (Joyee Cheung)
    [#25828](#25828)
  * improve `--redirect-warnings` handling (Ruben Bridgewater)
    [#24965](#24965)
* readline:
  * support TERM=dumb (Vladislav Kaminsky)
    [#26261](#26261)
* repl:
  * add welcome message (gengjiawen)
    [#25947](#25947)
  * fix terminal default setting (Ruben Bridgewater)
    [#26518](#26518)
  * check colors with .getColorDepth() (Vladislav Kaminsky)
    [#26261](#26261)
  * deprecate REPLServer.rli (Ruben Bridgewater)
    [#26260](#26260)
* src:
  * remove unused INT\_MAX constant (Sam Roberts)
    [#27078](#27078)
  * update NODE\_MODULE\_VERSION to 72 (Ujjwal Sharma)
    [#26685](#26685)
  * remove `AddPromiseHook()` (Anna Henningsen)
    [#26574](#26574)
  * update NODE\_MODULE\_VERSION to 71 (Michaël Zasso)
    [#25852](#25852)
  * clean up MultiIsolatePlatform interface (Anna Henningsen)
    [#26384](#26384)
  * properly configure default heap limits (Ali Ijaz Sheikh)
    [#25576](#25576)
  * remove icuDataDir from node config (GauthamBanasandra)
    [#24780](#24780)
  * explicitly allow JS in ReadHostObject (Yang Guo)
    [#23423](#23423)
  * update postmortem constant (cjihrig)
    [#23423](#23423)
  * update NODE\_MODULE\_VERSION to 68 (Michaël Zasso)
    [#23423](#23423)
* tls:
  * support TLSv1.3 (Sam Roberts)
    [#26209](#26209)
  * return correct version from getCipher() (Sam Roberts)
    [#26625](#26625)
  * check arg types of renegotiate() (Sam Roberts)
    [#25876](#25876)
  * add code for ERR\_TLS\_INVALID\_PROTOCOL\_METHOD (Sam Roberts)
    [#24729](#24729)
  * emit a warning when servername is an IP address (Rodger Combs)
    [#23329](#23329)
  * disable TLS v1.0 and v1.1 by default (Ben Noordhuis)
    [#23814](#23814)
  * remove unused arg to createSecureContext() (Sam Roberts)
    [#24241](#24241)
  * deprecate Server.prototype.setOptions() (cjihrig)[
    #23820](#23820)
  * load NODE\_EXTRA\_CA\_CERTS at startup (Ouyang Yadong)
    [#23354](#23354)
* util:
  * change inspect compact and breakLength default (Ruben Bridgewater)
    [#27109](#27109)
  * improve inspect edge cases (Ruben Bridgewater)
    [#27109](#27109)
  * only the first line of the error message (Simon Zünd)
    [#26685](#26685)
  * don't set the prototype of callbackified functions
    (Ruben Bridgewater)
    [#26893](#26893)
  * rename callbackified function (Ruben Bridgewater)
    [#26893](#26893)
  * increase function length when using `callbackify()`
    (Ruben Bridgewater)
    [#26893](#26893)
  * prevent tampering with internals in `inspect()` (Ruben Bridgewater)
    [#26577](#26577)
  * fix proxy inspection (Ruben Bridgewater)
    [#26241](#26241)
  * prevent leaking internal properties (Ruben Bridgewater)
    [#24971](#24971)
  * protect against monkeypatched Object prototype for inspect()
    (Rich Trott)
    [#25953](#25953)
  * treat format arguments equally (Roman Reiss)
    [#23162](#23162)
* win, fs:
  * detect if symlink target is a directory (Bartosz Sosnowski)
    [#23724](#23724)
* zlib:
  * throw TypeError if callback is missing (Anna Henningsen)[
    #24929](#24929)
  * make “bare” constants un-enumerable (Anna Henningsen)
    [#24824](#24824)

PR-URL: #26930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.