Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: migrate to getOptions() #23562

Closed
wants to merge 1 commit into from

Conversation

@nick-ng
Copy link
Contributor

commented Oct 12, 2018

Migrating from process.binding('config') to getOptions() in crypto.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
crypto: migrate to getOptions()
Migrating from process.binding('config') to getOptions() in crypto.js
@danbev

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

@nick-ng

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

Can I have some advice on how to fix the failing tests?

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

@nick-ng These should be unrelated to this PR, nothing to worry about…

New Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17932/

@Trott

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

@tniessen

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

Landed in 4e96845, thank you for your contribution!

@tniessen tniessen closed this Oct 19, 2018

tniessen added a commit that referenced this pull request Oct 19, 2018

crypto: migrate to getOptions()
Migrating from process.binding('config') to getOptions() in crypto.js.

PR-URL: #23562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

jasnell added a commit that referenced this pull request Oct 21, 2018

crypto: migrate to getOptions()
Migrating from process.binding('config') to getOptions() in crypto.js.

PR-URL: #23562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.