Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Covering the case when fs-read get invalid argument for file ha… #23601

Closed

Conversation

@leomoreno
Copy link
Contributor

leomoreno commented Oct 12, 2018

fs read checks that first parameter is a valid FileHandle object.
Here we are wrapping that case with test.

  • [ X ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ X ] tests and/or benchmarks are included
  • [ X ] commit message follows [commit guidelines]
@addaleax addaleax added the fs label Oct 12, 2018
@addaleax

This comment has been minimized.

Covering the case when fs-read get invalid argument for file handle
@leomoreno leomoreno force-pushed the leomoreno:coverage-fd-invalid-arg-type branch from 4f17346 to 36e9ada Oct 12, 2018
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 12, 2018

Collaborators, 👍 here to approve fast-tracking of this PR.

@Trott Trott added the fast-track label Oct 12, 2018
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 12, 2018

Trott added a commit to Trott/io.js that referenced this pull request Oct 13, 2018
Covering the case when fs-read get invalid argument for file handle

PR-URL: nodejs#23601
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 13, 2018

Landed in c24e963

@Trott Trott closed this Oct 13, 2018
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 13, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@leomoreno leomoreno deleted the leomoreno:coverage-fd-invalid-arg-type branch Oct 15, 2018
burgerboydaddy added a commit to burgerboydaddy/node that referenced this pull request Oct 17, 2018
Covering the case when fs-read get invalid argument for file handle

PR-URL: nodejs#23601
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
jasnell added a commit that referenced this pull request Oct 17, 2018
Covering the case when fs-read get invalid argument for file handle

PR-URL: #23601
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax added a commit that referenced this pull request Oct 20, 2018
Covering the case when fs-read get invalid argument for file handle

PR-URL: #23601
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins added a commit that referenced this pull request Oct 30, 2018
Covering the case when fs-read get invalid argument for file handle

PR-URL: #23601
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
Covering the case when fs-read get invalid argument for file handle

PR-URL: #23601
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
Covering the case when fs-read get invalid argument for file handle

PR-URL: #23601
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.