Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix assertions args order in test-http-chunk-problem.js #23608

Closed
wants to merge 1 commit into from
Closed

test: fix assertions args order in test-http-chunk-problem.js #23608

wants to merge 1 commit into from

Conversation

@milsosa
Copy link
Contributor

milsosa commented Oct 12, 2018 •
edited

Fix assertions arguments order in test-http-chunk-problem.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@jasnell
jasnell approved these changes Oct 12, 2018
View changes
@addaleax
addaleax approved these changes Oct 12, 2018
View changes
@BridgeAR
BridgeAR approved these changes Oct 12, 2018
View changes
@trivikr
trivikr approved these changes Oct 12, 2018
View changes
@cjihrig
cjihrig approved these changes Oct 12, 2018
View changes
@gireeshpunathil
gireeshpunathil approved these changes Oct 13, 2018
View changes
@thefourtheye
thefourtheye approved these changes Oct 13, 2018
View changes
BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@milsosa @BridgeAR
test: fix assertions args order
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
685a8c5 
PR-URL: nodejs#23608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@milsosa

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

milsosa commented Oct 15, 2018

One of this PR's builds failed due to the title-length validation.

✖  0:72     Title must be <= 72 columns.              title-length

How can/should I fix this?

Failed Build
@thefourtheye

This comment has been minimized.

Sign in to view
Copy link
Contributor

thefourtheye commented Oct 15, 2018

@milsosa The failure means that the commit message doesn't conform to the guidelines. You can use git commit --amend command to fix it yourself.
@milsosa
test: fix assertions args order in test-http-chunk-problem.js
Loading status checks…
8be3af7
@milsosa milsosa force-pushed the milsosa:fix-assertions-http-chunk branch from f4757fe to 8be3af7 Oct 15, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@milsosa @BridgeAR
test: fix assertions args order
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
31cb297 
PR-URL: nodejs#23608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Oct 15, 2018 •
edited

Landed in 31cb297 🎉

@milsosa congratulations on your commit to Node.js!
@BridgeAR BridgeAR closed this Oct 15, 2018
@milsosa

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

milsosa commented Oct 15, 2018

Thanks @thefourtheye and @BridgeAR!
@milsosa milsosa deleted the milsosa:fix-assertions-http-chunk branch Oct 15, 2018
burgerboydaddy added a commit to burgerboydaddy/node that referenced this pull request Oct 17, 2018
@milsosa @burgerboydaddy
test: fix assertions args order
52ccd53 
PR-URL: nodejs#23608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell added a commit that referenced this pull request Oct 17, 2018
@milsosa @jasnell
test: fix assertions args order
Verified
This commit was signed with a verified signature.
jasnell James M Snell
GPG key ID: 7341B15C070877AC Learn about signing commits
50a280a 
PR-URL: #23608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax added a commit that referenced this pull request Oct 20, 2018
@milsosa @addaleax
test: fix assertions args order
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
6173ebf 
PR-URL: #23608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 30, 2018
@milsosa @MylesBorins
test: fix assertions args order
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
37e1101 
PR-URL: #23608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg added a commit that referenced this pull request Nov 28, 2018
@milsosa @rvagg
test: fix assertions args order
71dc881 
PR-URL: #23608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
@milsosa @MylesBorins
test: fix assertions args order
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
61cf1cf 
PR-URL: #23608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@thefourtheye thefourtheye

@addaleax addaleax

@cjihrig cjihrig

@gireeshpunathil gireeshpunathil

@BridgeAR BridgeAR

@trivikr trivikr

Assignees
No one assigned
Labels
code-and-learn fast-track http test
Projects
None yet
Milestone
No milestone
9 participants
@milsosa @thefourtheye @BridgeAR @jasnell @addaleax @cjihrig @gireeshpunathil @trivikr @nodejs-github-bot
You can’t perform that action at this time.