Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win, fs: detect if symlink target is a directory #23724

Closed
wants to merge 2 commits into from
Closed

win, fs: detect if symlink target is a directory #23724

wants to merge 2 commits into from

Commits on Nov 29, 2018

  1. win, fs: detect if symlink target is a directory 

    On Windows creating a symlink to a directory will not work unless extra
'dir' parameter is passed. This adds a check if link target is a
directory, and if so automatically use 'dir' when creating symlink.

Ref: nodejs#23691
    @bzoz
    bzoz committed Nov 29, 2018
    Copy the full SHA
    7abe623 View commit details
    Browse the repository at this point in the history

  2. fixup

    @bzoz
    bzoz committed Nov 29, 2018
    Copy the full SHA
    e8646bf View commit details
    Browse the repository at this point in the history