Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: reduce duplication in tcp_wrap Connect #23753

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented Oct 19, 2018

This commit extracts identical code from Connect and Connect6 into a
separate function to avoid some code duplication.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: reduce duplication in tcp_wrap Connect
This commit extracts identical code from Connect and Connect6 into a
separate function to avoid some code duplication.
@danbev

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2018

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 24, 2018

@mmarchini

This comment has been minimized.

Copy link
Member

commented Oct 24, 2018

Landed in d568b53

@mmarchini mmarchini closed this Oct 24, 2018

mmarchini added a commit that referenced this pull request Oct 24, 2018
src: reduce duplication in tcp_wrap Connect
This commit extracts identical code from Connect and Connect6 into a
separate function to avoid some code duplication.

PR-URL: #23753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
targos added a commit that referenced this pull request Oct 26, 2018
src: reduce duplication in tcp_wrap Connect
This commit extracts identical code from Connect and Connect6 into a
separate function to avoid some code duplication.

PR-URL: #23753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@targos targos referenced this pull request Oct 27, 2018
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

Lands cleanly on 10.x, opted to not backport to 8.x

MylesBorins added a commit that referenced this pull request Nov 26, 2018
src: reduce duplication in tcp_wrap Connect
This commit extracts identical code from Connect and Connect6 into a
separate function to avoid some code duplication.

PR-URL: #23753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
src: reduce duplication in tcp_wrap Connect
This commit extracts identical code from Connect and Connect6 into a
separate function to avoid some code duplication.

PR-URL: #23753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
src: reduce duplication in tcp_wrap Connect
This commit extracts identical code from Connect and Connect6 into a
separate function to avoid some code duplication.

PR-URL: #23753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@codebytere codebytere referenced this pull request Nov 29, 2018

@danbev danbev deleted the danbev:tcp_wrap_connect branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.