Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note about removeListener order #23762

Closed
wants to merge 1 commit into from

Conversation

@jasnell
Copy link
Member

commented Oct 19, 2018

Fixes: #21635

Checklist
@jasnell

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2018

Please 👍 to fast-track

doc/api/events.md Outdated Show resolved Hide resolved
doc/api/events.md Outdated Show resolved Hide resolved
@lpinca
lpinca approved these changes Oct 21, 2018

@jasnell jasnell force-pushed the jasnell:events-removelistener-order branch from c9cbf95 to 2f8098d Oct 23, 2018

@jasnell

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

Landed in 2f8098d

@jasnell jasnell closed this Oct 23, 2018

@jasnell jasnell reopened this Oct 23, 2018

@jasnell

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

Sorry... heh... mixed up the PRs lol

jasnell added a commit that referenced this pull request Oct 23, 2018
doc: add note about removeListener order
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

Landed in b049d55

@jasnell jasnell closed this Oct 23, 2018

targos added a commit that referenced this pull request Oct 24, 2018
doc: add note about removeListener order
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos referenced this pull request Oct 27, 2018
MylesBorins added a commit that referenced this pull request Nov 26, 2018
doc: add note about removeListener order
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 26, 2018
doc: add note about removeListener order
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: add note about removeListener order
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: add note about removeListener order
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
doc: add note about removeListener order
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
@BethGriggs BethGriggs referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.