Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document ACL limitation for fs.access on Windows #23772

Closed
wants to merge 1 commit into from

Conversation

@jasnell
Copy link
Member

commented Oct 19, 2018

Fixes: #19192

Checklist
@jasnell

This comment has been minimized.

Copy link
Member Author

commented Oct 19, 2018

Please 👍 to fast-track

On Windows, access-control policies (ACLs) on a directory may limit access to
a file or directory. The `fs.access()` function, however, does not check the
ACL and therefore may report that a path is accessible even if the ACL restricts
the user from reading or writing to it.

This comment has been minimized.

Copy link
@sam-github

sam-github Oct 20, 2018

Member

Perhaps add one more sentence reminding of the "not recommended" race conditions above, and how this quirk of ACLs makes it even more important to not misuse fs.access() in the ways described.

This comment has been minimized.

Copy link
@jasnell

jasnell Oct 23, 2018

Author Member

Can do that in a separate PR

@lpinca
lpinca approved these changes Oct 20, 2018
@bzoz
bzoz approved these changes Oct 22, 2018
@bzoz
bzoz approved these changes Oct 22, 2018
jasnell added a commit that referenced this pull request Oct 23, 2018
doc: document ACL limitation for fs.access on Windows
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@jasnell

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2018

Landed in 6c07990

@jasnell jasnell closed this Oct 23, 2018

targos added a commit that referenced this pull request Oct 24, 2018
doc: document ACL limitation for fs.access on Windows
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@targos targos referenced this pull request Oct 27, 2018
MylesBorins added a commit that referenced this pull request Nov 26, 2018
doc: document ACL limitation for fs.access on Windows
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins added a commit that referenced this pull request Nov 26, 2018
doc: document ACL limitation for fs.access on Windows
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: document ACL limitation for fs.access on Windows
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: document ACL limitation for fs.access on Windows
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
doc: document ACL limitation for fs.access on Windows
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.