New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: support top-level for-await-of #23841

Closed
wants to merge 1 commit into
base: master
from

Conversation

@codebytere
Member

codebytere commented Oct 24, 2018

Resolves #23836.

Ensures that visitors check for a for-of statement with await: true so that state.containsAwait is then properly handled.

/cc @devsnek

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

Trott approved these changes Oct 24, 2018

@Trott

This comment has been minimized.

@Trott Trott added the author ready label Oct 24, 2018

@@ -11,6 +11,12 @@ const visitorsWithoutAncestors = {
}
walk.base.ClassDeclaration(node, state, c);
},
ForOfStatement(node, state, c) {

This comment has been minimized.

@TimothyGu

TimothyGu Oct 24, 2018

Member

nit: for parity with Chromium code, I would move this to right after AwaitExpression.

@Trott

This comment has been minimized.

Member

Trott commented Oct 26, 2018

@targos

This comment has been minimized.

Member

targos commented Oct 28, 2018

Landed in 35f9cd2

@targos targos closed this Oct 28, 2018

targos added a commit that referenced this pull request Oct 28, 2018

repl: support top-level for-await-of
PR-URL: #23841
Fixes: #23836
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Oct 28, 2018

repl: support top-level for-await-of
PR-URL: #23841
Fixes: #23836
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Oct 28, 2018

2018-10-30, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

@targos targos referenced this pull request Oct 28, 2018

Merged

Release proposal: v11.1.0 #23922

@codebytere codebytere deleted the codebytere:fix-for-await-of branch Oct 28, 2018

targos added a commit that referenced this pull request Nov 1, 2018

repl: support top-level for-await-of
PR-URL: #23841
Fixes: #23836
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Nov 1, 2018

2018-11-02, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

targos added a commit that referenced this pull request Nov 2, 2018

2018-11-02, Version 11.1.0 (Current)
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment