New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to c-ares v1.15.0 #23854

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
7 participants

bnoordhuis added some commits Oct 24, 2018

deps: remove old c-ares configure files
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.
deps: upgrade to c-ares v1.15.0
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.
@refack

This comment has been minimized.

Copy link
Member

refack commented Oct 24, 2018

Probably should remove:

'common.gypi',

@refack

refack approved these changes Oct 24, 2018

Copy link
Member

refack left a comment

gyp changes LGTM
RSLGTM on c-ares bump

@bnoordhuis

This comment has been minimized.

Copy link
Member

bnoordhuis commented Oct 26, 2018

CI once more: https://ci.nodejs.org/job/node-test-pull-request/18178/ (edit: green)

Previous one had a couple of (what are probably) flakes.

@Trott

This comment has been minimized.

Copy link
Member

Trott commented Nov 6, 2018

Any reason this shouldn't land? Seems ready to go. (Should it land as one, two, or three separate commits?)

@addaleax

This comment has been minimized.

Copy link
Member

addaleax commented Nov 6, 2018

Landed in aa82a21...7b1297d

@addaleax addaleax closed this Nov 6, 2018

@addaleax addaleax referenced this pull request Nov 6, 2018

Open

dns: support cares_search for resolution #22226

4 of 4 tasks complete

addaleax added a commit that referenced this pull request Nov 6, 2018

deps: remove old c-ares configure files
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request Nov 6, 2018

deps: upgrade to c-ares v1.15.0
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit that referenced this pull request Nov 6, 2018

deps: c-ares float, version number patch
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos added a commit that referenced this pull request Nov 6, 2018

deps: remove old c-ares configure files
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos added a commit that referenced this pull request Nov 6, 2018

deps: upgrade to c-ares v1.15.0
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos added a commit that referenced this pull request Nov 6, 2018

deps: c-ares float, version number patch
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@BridgeAR BridgeAR referenced this pull request Nov 14, 2018

Merged

Release proposal: v11.2 #24350

codebytere added a commit that referenced this pull request Nov 29, 2018

deps: remove old c-ares configure files
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere added a commit that referenced this pull request Nov 29, 2018

deps: upgrade to c-ares v1.15.0
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere added a commit that referenced this pull request Nov 29, 2018

deps: c-ares float, version number patch
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 29, 2018

deps: remove old c-ares configure files
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 29, 2018

deps: upgrade to c-ares v1.15.0
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 29, 2018

deps: c-ares float, version number patch
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@codebytere codebytere referenced this pull request Nov 29, 2018

Merged

v10.14.2 proposal #24727

MylesBorins added a commit that referenced this pull request Dec 3, 2018

deps: remove old c-ares configure files
Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 3, 2018

deps: upgrade to c-ares v1.15.0
Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 3, 2018

deps: c-ares float, version number patch
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 6, 2018

2018-12-11, Version 10.14.2 'Dubnium' (LTS)
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727

MylesBorins added a commit that referenced this pull request Dec 11, 2018

2018-12-11, Version 10.14.2 'Dubnium' (LTS)
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

2018-12-11, Version 10.14.2 'Dubnium' (LTS)
Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    nodejs#23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    nodejs#23822
* Added new collaborators:
  * Peter Marshall. nodejs#24170
  * Masashi Hirano. nodejs#24136

PR-URL: nodejs#24727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment