Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add decode & encode method in querystring.md #23889

Closed
wants to merge 1 commit into from

Conversation

@ZYSzys
Copy link
Member

commented Oct 26, 2018

I found there are querystring.decode method and querystring.encode in the querystring.js but they are not shown on the document. So maybe we need to add these right ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@ZYSzys ZYSzys force-pushed the zys-contribs:doc/qs branch 2 times, most recently from df41e02 to 2ea5f03 Feb 10, 2019

@ZYSzys

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2019

/cc @nodejs/documentation . Should we add querystring.decode method and querystring.encode into querystring.md ?

doc/api/querystring.md Outdated Show resolved Hide resolved
doc/api/querystring.md Outdated Show resolved Hide resolved
doc/api/querystring.md Outdated Show resolved Hide resolved
doc/api/querystring.md Outdated Show resolved Hide resolved

@ZYSzys ZYSzys force-pushed the zys-contribs:doc/qs branch from 2ea5f03 to 6dd9a66 Feb 14, 2019

@ZYSzys ZYSzys force-pushed the zys-contribs:doc/qs branch from 6dd9a66 to e3fdb15 Feb 14, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

I cannot dig up the exact links but I vaguely remember this was brought up once and the decision was to keep the two undocumented, deprecate them, and eventually remove them.

@jasnell @TimothyGu (?)

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Is this ready to be landed?

@BridgeAR
Copy link
Member

left a comment

I guess it does not hurt to have the alias in place.

@vsemozhetbyt

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

Landed in fb54968
Thank you!

vsemozhetbyt added a commit that referenced this pull request Mar 10, 2019
doc: add decode() & encode() methods into querystring.md
PR-URL: #23889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@ZYSzys ZYSzys deleted the zys-contribs:doc/qs branch Mar 10, 2019

BridgeAR added a commit that referenced this pull request Mar 13, 2019
doc: add decode() & encode() methods into querystring.md
PR-URL: #23889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request Mar 13, 2019
doc: add decode() & encode() methods into querystring.md
PR-URL: #23889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
doc: add decode() & encode() methods into querystring.md
PR-URL: #23889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs added a commit that referenced this pull request Apr 16, 2019
doc: add decode() & encode() methods into querystring.md
PR-URL: #23889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.