Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make example more clarified in cluster.md #23931

Closed
wants to merge 3 commits into from

Conversation

@ZYSzys
Copy link
Member

commented Oct 28, 2018

Make example explanation more clarified in cluster Event:'message'.

Refs: #23930

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
Copy link
Member

left a comment

Instead of adding a new sentence, clarify in the existing sentence?:

Here is a cluster that uses the message system to keep a count in the master
process of the number of HTTP requests received by the workers:
@Trott

This comment has been minimized.

Copy link
Member

commented Oct 28, 2018

Or maybe even better, split into two sentences:

Here is an example using the message system. It keeps a count in the master
process of the number of HTTP requests received by the workers:
@ZYSzys

This comment has been minimized.

Copy link
Member Author

commented Oct 28, 2018

How about now ?

process of the number of HTTP requests received by the workers:

Note that when this example running, you need to open browser and visit `http://localhost:8000`
or open another terminal window and run `curl http://localhost:8000` to see `numReqs` increasing.

This comment has been minimized.

Copy link
@Trott

Trott Oct 28, 2018

Member

I don't think the new sentence is necessary with the changes to the existing sentence.

@Trott
Trott approved these changes Oct 28, 2018
@vsemozhetbyt

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Oct 28, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@lpinca
lpinca approved these changes Oct 28, 2018

@trivikr trivikr added the fast-track label Oct 29, 2018

@trivikr

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

Landed in 2061843

@trivikr trivikr closed this Oct 29, 2018

trivikr added a commit that referenced this pull request Oct 29, 2018
doc: make example more clarified in cluster.md
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@ZYSzys ZYSzys deleted the zys-contribs:cluster branch Oct 29, 2018

targos added a commit that referenced this pull request Nov 1, 2018
doc: make example more clarified in cluster.md
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos referenced this pull request Nov 1, 2018
MylesBorins added a commit that referenced this pull request Nov 26, 2018
doc: make example more clarified in cluster.md
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 26, 2018
doc: make example more clarified in cluster.md
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: make example more clarified in cluster.md
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: make example more clarified in cluster.md
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
doc: make example more clarified in cluster.md
PR-URL: #23931
Refs: #23930
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
@BethGriggs BethGriggs referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.