Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: moved test instructions to BUILDING.md #23949

Closed
wants to merge 3 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 29, 2018

Fixes: #23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

Checklist

Fixes: nodejs#23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 29, 2018
@trivikr trivikr self-assigned this Oct 29, 2018
BUILDING.md Outdated Show resolved Hide resolved
@richardlau
Copy link
Member

The coverage instructions should probably point out that it is non-Windows (AFAIK). Can be done in another PR as it wasn't in the original text.

BUILDING.md Outdated Show resolved Hide resolved
vsemozhetbyt and others added 2 commits October 29, 2018 17:13
Co-Authored-By: trivikr <16024985+trivikr@users.noreply.github.com>
@trivikr
Copy link
Member Author

trivikr commented Oct 30, 2018

@trivikr
Copy link
Member Author

trivikr commented Oct 31, 2018

Landed in 8c244dd

@trivikr trivikr closed this Oct 31, 2018
@trivikr trivikr deleted the update-test-instructions branch October 31, 2018 06:03
trivikr added a commit to trivikr/node that referenced this pull request Oct 31, 2018
Fixes: nodejs#23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

PR-URL: nodejs#23949
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this pull request Nov 1, 2018
Fixes: #23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

PR-URL: #23949
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorins
Copy link
Member

This does not land cleanly on 8.x or 10.x

As 8.x is near maintenance I'm setting as don't land, but perhaps we should backport to 10.x

@trivikr
Copy link
Member Author

trivikr commented Nov 30, 2018

These test instructions are for working on NodeJS core, so it's good as long as they're in master.
They need not be back-ported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node core building instructions in one place
10 participants