Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix compiler warning #23954

Closed
wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

commented Oct 29, 2018

The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
src: fix compiler warning
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);
@danbev
danbev approved these changes Oct 29, 2018
@bnoordhuis
Copy link
Member

left a comment

Duplicate of #23910?


I'll get my coat.

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2018

@bnoordhuis oops. Would you rather land 4e10934?

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

Don't worry, it's fine. :-)

@refack refack referenced this pull request Oct 29, 2018
3 of 3 tasks complete
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2018

@joyeecheung

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

Landed in 93335cb

joyeecheung added a commit that referenced this pull request Oct 30, 2018
src: fix compiler warning
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@richardlau

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

Landed in 93335cb

@joyeecheung Did ncu let this through? It's been open < 48 hours and wasn't fast tracked either.

(Just to be clear, I have no issue with the change itself, just the process.)

@joyeecheung

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

@richardlau oops, my bad, I ignored the warning because I assumed this was fast-tracked

@cjihrig cjihrig deleted the cjihrig:warning branch Oct 30, 2018

refack added a commit to refack/node that referenced this pull request Oct 31, 2018
build: add -Werror=undefined-inline to clang builds
PR-URL: nodejs#23961
Refs: nodejs#23954
Refs: nodejs#23910
Refs: nodejs#23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Depends on #23808 to land on v11.x-staging

@targos targos added this to Don't land (for now) in v11.x Nov 2, 2018

targos added a commit that referenced this pull request Nov 2, 2018
build: add -Werror=undefined-inline to clang builds
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this pull request Nov 18, 2018
src: fix compiler warning
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
MylesBorins added a commit that referenced this pull request Nov 27, 2018
build: add -Werror=undefined-inline to clang builds
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
build: add -Werror=undefined-inline to clang builds
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
src: fix compiler warning
The warning is:

../src/util.h:65:11: warning: inline function
'node::Calloc<unsigned char>' is not defined [-Wundefined-inline]
inline T* Calloc(size_t n);
          ^
../src/aliased_buffer.h:41:15: note: used here
    buffer_ = Calloc<NativeT>(count);

PR-URL: #23954
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
build: add -Werror=undefined-inline to clang builds
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 3, 2018
build: add -Werror=undefined-inline to clang builds
PR-URL: #23961
Refs: #23954
Refs: #23910
Refs: #23880
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
@codebytere

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

Adding the above label as patch application reports:
No changes -- Patch already applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.