Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix headings for CHANGELOG_v10.md #23973

Closed
wants to merge 1 commit into from

Conversation

Projects
10 participants
@MylesBorins
Copy link
Member

commented Oct 30, 2018

The LTS bit flip did not include the new title heading for LTS in the
changelog. This commit fixes that.

@targos

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

Can it land on master first?

@lpinca

lpinca approved these changes Oct 30, 2018

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

@targos that makes sense. It should Target master

@MylesBorins MylesBorins changed the base branch from v10.x-staging to master Oct 31, 2018

doc: fix headings for CHANGELOG_v10.md
The LTS bit flip did not include the new title heading for LTS in the
changelog. This commit fixes that.

@MylesBorins MylesBorins force-pushed the MylesBorins:fix-10.x-changelog branch from a7ebf2e to c131048 Oct 31, 2018

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2018

i've targetted against master

MylesBorins added a commit that referenced this pull request Nov 1, 2018

doc: fix headings for CHANGELOG_v10.md
The LTS bit flip did not include the new title heading for LTS in the
changelog. This commit fixes that.

PR-URL: #23973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@MylesBorins MylesBorins closed this Nov 1, 2018

@MylesBorins MylesBorins reopened this Nov 1, 2018

@MylesBorins MylesBorins removed the v10.x label Nov 1, 2018

@danbev

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Landed in db2ac1d.

@danbev danbev closed this Nov 2, 2018

danbev added a commit that referenced this pull request Nov 2, 2018

doc: fix headings for CHANGELOG_v10.md
The LTS bit flip did not include the new title heading for LTS in the
changelog. This commit fixes that.

PR-URL: #23973
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@targos targos added this to Don't land (ever) in v11.x Nov 14, 2018

@codebytere codebytere referenced this pull request Nov 27, 2018

Closed

v10.13.1 proposal #24675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.