Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-fs-watch-system-limit #23986

Closed
wants to merge 1 commit into from

Conversation

@ofrobots
Copy link
Contributor

commented Oct 31, 2018

On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

CI: https://ci.nodejs.org/job/node-test-pull-request/18272/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: fix test-fs-watch-system-limit
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

@ofrobots ofrobots requested a review from addaleax Oct 31, 2018

@richardlau

This comment was marked as outdated.

Copy link
Member

commented Oct 31, 2018

Possibly applicable to other tests too: #21310

Edit: Sorry, the other issue is hitting limits (inotify limits possibly too low) which is the exact opposite of this (inotify limits too high).

@lpinca
lpinca approved these changes Oct 31, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 2, 2018
test: fix test-fs-watch-system-limit
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: nodejs#23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

Landed in a03165a

@Trott Trott closed this Nov 2, 2018

targos added a commit that referenced this pull request Nov 2, 2018
test: fix test-fs-watch-system-limit
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Nov 14, 2018
MylesBorins added a commit that referenced this pull request Nov 27, 2018
test: fix test-fs-watch-system-limit
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere referenced this pull request Nov 27, 2018
rvagg added a commit that referenced this pull request Nov 28, 2018
test: fix test-fs-watch-system-limit
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
test: fix test-fs-watch-system-limit
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
MylesBorins added a commit that referenced this pull request Dec 3, 2018
test: fix test-fs-watch-system-limit
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.