Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: add test case for close before connect #24054

Closed
wants to merge 1 commit into from

Conversation

@antsmartian
Copy link
Contributor

commented Nov 3, 2018

Test wasn't covering few lines http2 code coverage. Added test for the same.

/ cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@antsmartian antsmartian changed the title http: add test case for goaway scenario http: add test case for goaway Nov 3, 2018

@antsmartian antsmartian force-pushed the antsmartian:test-goaway branch 2 times, most recently from a58bcb1 to 6ee8f4f Nov 3, 2018

@antsmartian antsmartian changed the title http: add test case for goaway test: http2 add test case for close before connect Nov 3, 2018

@antsmartian antsmartian force-pushed the antsmartian:test-goaway branch from 6ee8f4f to 8efadc8 Nov 3, 2018

@antsmartian antsmartian changed the title test: http2 add test case for close before connect http2: add test case for close before connect Nov 3, 2018

@antsmartian antsmartian force-pushed the antsmartian:test-goaway branch from 8efadc8 to ee03b7d Nov 3, 2018

@antsmartian antsmartian force-pushed the antsmartian:test-goaway branch from ee03b7d to e60bbdc Nov 3, 2018

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

Bump @jasnell

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

@jasnell
jasnell approved these changes Jan 9, 2019
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@antsmartian

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Landed in 7f91329 🎉

antsmartian added a commit that referenced this pull request Jan 14, 2019
http2: add test case for goaway
PR-URL: #24054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@antsmartian antsmartian deleted the antsmartian:test-goaway branch Jan 14, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019
http2: add test case for goaway
PR-URL: #24054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
http2: add test case for goaway
PR-URL: nodejs#24054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
BethGriggs added a commit that referenced this pull request Apr 28, 2019
http2: add test case for goaway
PR-URL: #24054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs referenced this pull request May 1, 2019
BethGriggs added a commit that referenced this pull request May 10, 2019
http2: add test case for goaway
PR-URL: #24054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request May 16, 2019
http2: add test case for goaway
PR-URL: #24054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.