Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add crypto check to test-benchmark-http2 #24096

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented Nov 5, 2018

Currently, this test will fail when configured --without-ssl. This
commit adds a crypto check to have this test skipped when configured
without crypto support.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: add crypto check to test-benchmark-http2
Currently, this test will fail when configured --without-ssl. This
commit adds a crypto check to have this test skipped when configured
without crypto support.
@danbev

This comment has been minimized.

Copy link
Member Author

commented Nov 5, 2018

@danbev danbev referenced this pull request Nov 5, 2018
2 of 2 tasks complete
@cjihrig
cjihrig approved these changes Nov 5, 2018
@lpinca
lpinca approved these changes Nov 5, 2018
@Trott
Trott approved these changes Nov 6, 2018

@Trott Trott added the fast-track label Nov 6, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

Collaborators: 👍 here to fast-track.

@Trott Trott added the author ready label Nov 6, 2018

@danbev

This comment has been minimized.

Copy link
Member Author

commented Nov 6, 2018

Landed in 615160c.

@danbev danbev closed this Nov 6, 2018

@danbev danbev deleted the danbev:crypto_checks_tests branch Nov 6, 2018

danbev added a commit that referenced this pull request Nov 6, 2018
test: add crypto check to test-benchmark-http2
Currently, this test will fail when configured --without-ssl. This
commit adds a crypto check to have this test skipped when configured
without crypto support.

PR-URL: #24096
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos added a commit that referenced this pull request Nov 6, 2018
test: add crypto check to test-benchmark-http2
Currently, this test will fail when configured --without-ssl. This
commit adds a crypto check to have this test skipped when configured
without crypto support.

PR-URL: #24096
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeAR BridgeAR referenced this pull request Nov 14, 2018
codebytere added a commit that referenced this pull request Nov 29, 2018
test: add crypto check to test-benchmark-http2
Currently, this test will fail when configured --without-ssl. This
commit adds a crypto check to have this test skipped when configured
without crypto support.

PR-URL: #24096
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins added a commit that referenced this pull request Nov 29, 2018
test: add crypto check to test-benchmark-http2
Currently, this test will fail when configured --without-ssl. This
commit adds a crypto check to have this test skipped when configured
without crypto support.

PR-URL: #24096
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebytere codebytere referenced this pull request Nov 29, 2018
MylesBorins added a commit that referenced this pull request Dec 3, 2018
test: add crypto check to test-benchmark-http2
Currently, this test will fail when configured --without-ssl. This
commit adds a crypto check to have this test skipped when configured
without crypto support.

PR-URL: #24096
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.