Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: swap the order of arguments #24134

Closed
wants to merge 1 commit into from

Conversation

@mhamwala
Copy link
Contributor

commented Nov 6, 2018

Swapped the actual and expected arguments in assert.strictEqual() calls.
Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
test: swap the order of arguments
Swapped the actual and expected arguments in `assert.strictEqual()` calls.
Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.
@cjihrig
cjihrig approved these changes Nov 6, 2018
@targos
targos approved these changes Nov 6, 2018
@mhamwala

This comment has been minimized.

Copy link
Contributor Author

commented Nov 6, 2018

@jasnell lgtm

@trivikr
trivikr approved these changes Nov 7, 2018
@gireeshpunathil

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 7, 2018

pls thumbs up for fast tracking

@gdams
gdams approved these changes Nov 7, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 8, 2018
test: swap the order of arguments
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: nodejs#24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

Landed in 2535aa5.

@Trott Trott closed this Nov 8, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018
test: swap the order of arguments
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: nodejs#24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Nov 14, 2018
test: swap the order of arguments
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: #24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@BridgeAR BridgeAR referenced this pull request Nov 14, 2018
kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
test: swap the order of arguments
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: nodejs#24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
codebytere added a commit that referenced this pull request Dec 13, 2018
test: swap the order of arguments
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: #24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
MylesBorins added a commit that referenced this pull request Dec 26, 2018
test: swap the order of arguments
Swapped the actual and expected arguments in `assert.strictEqual()`
calls.  Arguments are now in correct order.
Literal value is now the second argument and the value returned by the
function is the first argument.

PR-URL: #24134
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@codebytere codebytere referenced this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.