Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: swap expected and actual in assert.strictEqual #24146

Closed
wants to merge 1 commit into from

Conversation

@fbilbie
Copy link
Contributor

commented Nov 6, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig
cjihrig approved these changes Nov 6, 2018
@fbilbie fbilbie force-pushed the fbilbie:master branch from 16b30ad to d012767 Nov 6, 2018
assert.strictEqual(twoByteString.indexOf('\u03a3', -4, 'ucs2'), 6);
assert.strictEqual(twoByteString.indexOf('\u03a3', -6, 'ucs2'), 4);
assert.strictEqual(twoByteString.indexOf(
Buffer.from('\u03a3', 'ucs2'), -6, 'ucs2'), 4);
assert.strictEqual(-1, twoByteString.indexOf('\u03a3', -2, 'ucs2'));

This comment has been minimized.

Copy link
@trivikr

trivikr Nov 7, 2018

Member

The order needs to be swapped for -1 too - on this line and other lines

This comment has been minimized.

Copy link
@fbilbie

fbilbie Nov 7, 2018

Author Contributor

I thought that too, but the code an learn task was to change only a specific set of lines.

@trivikr

This comment has been minimized.

Copy link
Member

commented Nov 7, 2018

Hi @bilbieflorin, the author of this commit is not registered on Github (steps defined here)

Either:

  • add the email ID associated with the commit to Github
  • change the author of the commit to current email ID registered with the Github by following these steps
@fbilbie

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

Hi @trivikr! The git was configured with my work email. I added it to my github account and should be displaying the author correctly now.

Thanks for telling me about this!

@trivikr
trivikr approved these changes Nov 7, 2018
@gireeshpunathil

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

pls thumbs up for fast tracking

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

Landed in 791ad09.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 8, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 8, 2018
PR-URL: nodejs#24146
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018
PR-URL: nodejs#24146
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR added a commit that referenced this pull request Nov 14, 2018
PR-URL: #24146
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR referenced this pull request Nov 14, 2018
kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
PR-URL: nodejs#24146
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere added a commit that referenced this pull request Dec 13, 2018
PR-URL: #24146
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 26, 2018
PR-URL: #24146
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere referenced this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.