Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dgram bad arguments tests #24215

Closed

Conversation

@MarkArranz
Copy link
Contributor

commented Nov 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
sock.send();
}, TypeError); // First argument should be a buffer.
// First argument should be a buffer.
assert.throws(() => { sock.send(); }, TypeError);

This comment has been minimized.

Copy link
@lpinca

lpinca Nov 7, 2018

Member

Nit: we don't need both this and common. expectsError(), I'd keep only common. expectsError(). Same below.

This comment has been minimized.

Copy link
@MarkArranz

MarkArranz Nov 7, 2018

Author Contributor

I'll update accordingly. Thank you.

@lpinca
lpinca approved these changes Nov 8, 2018
@Trott
Trott approved these changes Nov 8, 2018
@Trott

This comment has been minimized.

@cjihrig
cjihrig approved these changes Nov 8, 2018

@Trott Trott added the author ready label Nov 8, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

Landed in 457cde3.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 9, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 9, 2018
test: add error code tests in dgram test
Improve error validation in test-dgram-send-bad-arguments.

PR-URL: nodejs#24215
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018
test: add error code tests in dgram test
Improve error validation in test-dgram-send-bad-arguments.

PR-URL: nodejs#24215
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Nov 14, 2018
test: add error code tests in dgram test
Improve error validation in test-dgram-send-bad-arguments.

PR-URL: #24215
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Nov 14, 2018
kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
test: add error code tests in dgram test
Improve error validation in test-dgram-send-bad-arguments.

PR-URL: nodejs#24215
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere added a commit that referenced this pull request Dec 14, 2018
test: add error code tests in dgram test
Improve error validation in test-dgram-send-bad-arguments.

PR-URL: #24215
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 26, 2018
test: add error code tests in dgram test
Improve error validation in test-dgram-send-bad-arguments.

PR-URL: #24215
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere referenced this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.