Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixed the arguments order in `assert.strictEqual` #24227

Conversation

@michael-zucker
Copy link
Contributor

commented Nov 7, 2018

This change was initiated from the NodeConfEU session.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
test: fixed the arguments order in `assert.strictEqual`
This change was initiated from the NodeConfEU session.
@cjihrig
cjihrig approved these changes Nov 7, 2018
@gireeshpunathil

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

failures seem to be unrelated, re-run to be absolutely safe.
new CI: https://ci.nodejs.org/job/node-test-pull-request/18479/

Trott added a commit to Trott/io.js that referenced this pull request Nov 10, 2018
test: fix the arguments order in `assert.strictEqual`
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24227
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

Landed in 6727f1c

@Trott Trott closed this Nov 10, 2018

tadhgcreedon pushed a commit to tadhgcreedon/node that referenced this pull request Nov 11, 2018
test: fix the arguments order in `assert.strictEqual`
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24227
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Nov 14, 2018
test: fix the arguments order in `assert.strictEqual`
This change was initiated from the NodeConfEU session.

PR-URL: #24227
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Nov 14, 2018
kiyomizumia added a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
test: fix the arguments order in `assert.strictEqual`
This change was initiated from the NodeConfEU session.

PR-URL: nodejs#24227
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
kanishk30 added a commit to kanishk30/node that referenced this pull request Nov 17, 2018
codebytere added a commit that referenced this pull request Dec 13, 2018
test: fix the arguments order in `assert.strictEqual`
This change was initiated from the NodeConfEU session.

PR-URL: #24227
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Dec 26, 2018
test: fix the arguments order in `assert.strictEqual`
This change was initiated from the NodeConfEU session.

PR-URL: #24227
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere referenced this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.