Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: check minimum ICU in configure for system-icu #24255

Merged
merged 1 commit into from Nov 17, 2018

Conversation

@srl295
Copy link
Member

commented Nov 8, 2018

  • check the version number coming out of pkg-config

Fixes: #24253

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@srl295 srl295 added the intl label Nov 8, 2018

@srl295 srl295 self-assigned this Nov 8, 2018

@srl295 srl295 requested review from refack, bnoordhuis and devsnek Nov 8, 2018

@srl295

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

else you get this:

root@4f4928358b09:/src/node# ./configure --with-intl=system-icu
ERROR: icu4c v60.2 is too old, v99.x or later is required.

also updates config.gypi, which wasn't set before. (icu_system_version is new here. icu_ver_major was set by the 'icu generic.gyp' code path, but not by system-icu previously)

                 'icu_system_version': '60.2',
                 'icu_ver_major': '60',
configure.py Outdated Show resolved Hide resolved
configure.py Outdated Show resolved Hide resolved
@devsnek
devsnek approved these changes Nov 8, 2018
@bnoordhuis
Copy link
Member

left a comment

If nothing uses/is going to use icu_system_version, can you remove it?

configure.py Outdated Show resolved Hide resolved
configure.py Outdated Show resolved Hide resolved
@srl295

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

@bnoordhuis I'll remove icu_system_version but keep icu_ver_major for consistency with the other path.

@srl295

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

@bnoordhuis thanks. I think I addressed your comments.

@refack
refack approved these changes Nov 8, 2018
@bnoordhuis
Copy link
Member

left a comment

LGTM with a comment.

configure.py Outdated Show resolved Hide resolved
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 16, 2018

@srl295 Looks like there's one nit from @bnoordhuis and a CI run and otherwise this is landable? Does that seem right to you?

@refack refack force-pushed the srl295:check-version-system-icu branch from 6695e84 to 2d0d9ce Nov 16, 2018

refack added a commit to srl295/node that referenced this pull request Nov 16, 2018
build: check minimum ICU in configure for system-icu
- check the version number coming out of pkg-config

PR-URL: nodejs#24255
Fixes: nodejs#24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack

This comment has been minimized.

refack added a commit to refack/node that referenced this pull request Nov 16, 2018
build: check minimum ICU in configure for system-icu
- check the version number coming out of pkg-config

PR-URL: nodejs#24255
Fixes: nodejs#24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

@refack refack force-pushed the srl295:check-version-system-icu branch from 2d0d9ce to 5c47c2b Nov 16, 2018

@refack

This comment has been minimized.

@Trott Trott added the author ready label Nov 17, 2018

build: check minimum ICU in configure for system-icu
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

@refack refack force-pushed the srl295:check-version-system-icu branch from 5c47c2b to ed1c40e Nov 17, 2018

@refack refack removed the author ready label Nov 17, 2018

@refack refack merged commit ed1c40e into nodejs:master Nov 17, 2018

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details
targos added a commit that referenced this pull request Nov 18, 2018
build: check minimum ICU in configure for system-icu
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
build: check minimum ICU in configure for system-icu
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 12, 2019
build: check minimum ICU in configure for system-icu
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
codebytere added a commit that referenced this pull request Jan 29, 2019
build: check minimum ICU in configure for system-icu
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.