Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update to remark-lint-preset-node@1.2.0 #24391

Closed
wants to merge 2 commits into from

Conversation

@Trott
Copy link
Member

commented Nov 16, 2018

Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.)

Minor formatting adjustments to two changelog files in preparation for the new markdown lint rule.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Trott added 2 commits Nov 16, 2018
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.
tools: update to remark-lint-preset-node@1.2.0
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

@Trott Trott added doc tools labels Nov 16, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 18, 2018

@nodejs/linting @nodejs/documentation This can use some reviews.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 19, 2018

Landed in dafd76c...3cac82f

@Trott Trott closed this Nov 19, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: nodejs#24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018
tools: update to remark-lint-preset-node@1.2.0
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: nodejs#24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos added a commit that referenced this pull request Nov 19, 2018
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos added a commit that referenced this pull request Nov 19, 2018
tools: update to remark-lint-preset-node@1.2.0
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
tools: update to remark-lint-preset-node@1.2.0
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere added a commit that referenced this pull request Jan 13, 2019
tools: update to remark-lint-preset-node@1.2.0
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: nodejs#24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
tools: update to remark-lint-preset-node@1.2.0
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: nodejs#24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins added a commit that referenced this pull request Jan 29, 2019
tools: update to remark-lint-preset-node@1.2.0
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
doc: udpate list item spacing in changelogs
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.