Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: improve code readability #24412

Closed
wants to merge 1 commit into from

Conversation

@gengjiawen
Copy link
Member

commented Nov 17, 2018

use object spread to make console code more readable

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
console: improve code readability
use object spread to make console code more readable
@addaleax

This comment has been minimized.

@Trott
Trott approved these changes Nov 20, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

Landed in 08c14d9

@Trott Trott closed this Nov 20, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2018
console: improve code readability
use object spread to make console code more readable

PR-URL: nodejs#24412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

Thanks for the contribution! 🎉

targos added a commit that referenced this pull request Nov 21, 2018
console: improve code readability
use object spread to make console code more readable

PR-URL: #24412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
console: improve code readability
use object spread to make console code more readable

PR-URL: #24412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
console: improve code readability
use object spread to make console code more readable

PR-URL: #24412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
console: improve code readability
use object spread to make console code more readable

PR-URL: nodejs#24412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
console: improve code readability
use object spread to make console code more readable

PR-URL: #24412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
console: improve code readability
use object spread to make console code more readable

PR-URL: #24412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.