Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replaced anonymous closure functions to arrow functions #24417

Closed
wants to merge 1 commit into from

Conversation

@Amanpreet-03
Copy link
Contributor

commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@Amanpreet-03 Amanpreet-03 force-pushed the Amanpreet-03:master branch from 1ca27e6 to 426dd50 Nov 17, 2018

@Amanpreet-03 Amanpreet-03 changed the title Replaced anonymous closure functions to arrow functions test: replaced anonymous closure functions to arrow functions Nov 17, 2018

@Amanpreet-03 Amanpreet-03 force-pushed the Amanpreet-03:master branch from 426dd50 to afdc14c Nov 17, 2018

@targos
targos approved these changes Nov 17, 2018
Copy link
Member

left a comment

Changes LGTM.

Commit message nit: s/replaced/replace/

@targos targos added the fast-track label Nov 17, 2018

@targos

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

👍 to fast-track

@Trott

This comment has been minimized.

@sagirk
sagirk approved these changes Nov 19, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

Landed in 35b996d

@Trott Trott closed this Nov 19, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018
test: replaced anonymous closure functions with arrow function
PR-URL: nodejs#24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018
test: replace anonymous closure functions with arrow function
PR-URL: nodejs#24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Nov 19, 2018
test: replace anonymous closure functions with arrow function
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: replace anonymous closure functions with arrow function
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
test: replace anonymous closure functions with arrow function
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: replace anonymous closure functions with arrow function
PR-URL: nodejs#24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: replace anonymous closure functions with arrow function
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: replace anonymous closure functions with arrow function
PR-URL: #24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.