Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: modified order of parameters for assertion #24430

Closed
wants to merge 1 commit into from

Conversation

@fiveobjects
Copy link

commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@targos
targos approved these changes Nov 17, 2018
Copy link
Member

left a comment

Changes LGTM.

Commit message should start with test: modify ...

@targos

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track label Nov 17, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

@fiveobjects -

  1. please see if you can make the changes that @targos suggested. It is something that we can do while landing; but appreciate if you make an attempt, as doing so strengthens the learning, to the spirit of the code & learn, thanks!

  2. if you'd like you can associate your email with your GitHub account. That way we and GitHub will credit the code contributions you make to you. See https://github.com/settings/emails and the guide at https://help.github.com/articles/setting-your-commit-email-address-on-github/

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

@@ -634,8 +634,8 @@ asyncTest(
const e = new Error('error');
const domainError = new Error('domain error');
onUnhandledSucceed(done, function(reason, promise) {

This comment has been minimized.

Copy link
@thefourtheye

thefourtheye Nov 20, 2018

Contributor

Nit: A common.mustCall around this would be better.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

That test-stream-pipeline issue is being pretty stubborn but is also pretty clearly unrelated. Let's do a full CI: https://ci.nodejs.org/job/node-test-pull-request/18815/

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2018
test: modify order of parameters for assertion
PR-URL: nodejs#24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

Landed in 7ba83e8.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 20, 2018

targos added a commit that referenced this pull request Nov 21, 2018
test: modify order of parameters for assertion
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: modify order of parameters for assertion
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
test: modify order of parameters for assertion
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: modify order of parameters for assertion
PR-URL: nodejs#24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: modify order of parameters for assertion
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: modify order of parameters for assertion
PR-URL: #24430
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.