Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change anonymous closure function to arrow function #24433

Closed

Conversation

@nethraravindran
Copy link
Contributor

commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@targos
targos approved these changes Nov 17, 2018
@targos

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track label Nov 17, 2018

@richardlau

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

This appears to make the test fail:

https://travis-ci.com/nodejs/node/jobs/159275096#L9045-L9062

=== release test-net-connect-options-port ===
Path: parallel/test-net-connect-options-port
/home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js:87
    const port = this.address().port;
                      ^
TypeError: this.address is not a function
    at Server.server.listen.common.mustCall (/home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js:87:23)
    at Server.<anonymous> (/home/travis/build/nodejs/node/test/common/index.js:346:15)
    at Object.onceWrapper (events.js:273:13)
    at Server.emit (events.js:182:13)
    at emitListeningNT (net.js:1320:10)
    at process.internalTickCallback (internal/process/next_tick.js:72:19)
Command: out/Release/node /home/travis/build/nodejs/node/test/parallel/test-net-connect-options-port.js
[06:06|% 100|+ 2430|-   1]: Done

@Trott Trott removed the fast-track label Nov 18, 2018

@sagirk
sagirk approved these changes Nov 19, 2018
@trivikr
Copy link
Member

left a comment

Explicitly mentioning Request changes

test/parallel/test-net-connect-options-port.js Outdated Show resolved Hide resolved

@nethraravindran nethraravindran force-pushed the nethraravindran:anonymous-arrow1 branch from 638a26d to 764cd4a Nov 22, 2018

@gireeshpunathil

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

@trivikr Change was made and test passes. LGTY?

addressed

@addaleax

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

Landed in 9eab803

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@addaleax addaleax closed this Nov 23, 2018

pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Nov 23, 2018
test: change anonymous closure function to arrow function
PR-URL: nodejs#24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos added a commit that referenced this pull request Nov 24, 2018
test: change anonymous closure function to arrow function
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: change anonymous closure function to arrow function
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
test: change anonymous closure function to arrow function
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: change anonymous closure function to arrow function
PR-URL: nodejs#24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: change anonymous closure function to arrow function
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: change anonymous closure function to arrow function
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: change anonymous closure function to arrow function
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: change anonymous closure function to arrow function
PR-URL: #24433
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.