Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor setupInspector in bootstrap/node.js #24446

Closed
wants to merge 1 commit into from

Conversation

@leeight
Copy link
Contributor

commented Nov 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@leeight leeight force-pushed the leeight:clean-bootstrap-node branch from af97483 to fa8b825 Nov 18, 2018

@oyyd

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

Hi @leeight. Thanks for your contribution! Can you add a short description about the change in the commit message? As Change-Id: Ic715201ba5eae43f7d535ff93045cb3a965d2752 seems a bit confuzing to me. You can find the guide here (which you may have known about before)

lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

@leeight leeight force-pushed the leeight:clean-bootstrap-node branch from fa8b825 to a4984e6 Nov 18, 2018

@leeight

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2018

@oyyd Thanks for your feedback. I updated the commit message and removed the Change-Id.

@oyyd

This comment has been minimized.

@oyyd
oyyd approved these changes Nov 18, 2018
Copy link
Member

left a comment

LGTM

@oyyd oyyd added the lib / src label Nov 18, 2018

@danbev
danbev approved these changes Nov 20, 2018
@danbev

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

Landed in 771585f.

@danbev danbev closed this Nov 20, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 20, 2018
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: nodejs#24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos added a commit that referenced this pull request Nov 20, 2018
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: nodejs#24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
lib: refactor setupInspector in bootstrap/node.js
`CJSModule` is not used in `setupGlobalConsole`, so we can move it to
`setupInspector` and remove the argument from `setupInspector`.

PR-URL: #24446
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.