Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix missing PR id #24458

Closed
wants to merge 1 commit into from

Conversation

Projects
6 participants
@oyyd
Copy link
Contributor

commented Nov 18, 2018

Refs: #23329

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Copy link

commented Nov 18, 2018

@oyyd sadly an error occured when I tried to trigger a build :(

@targos

targos approved these changes Nov 18, 2018

@vsemozhetbyt

This comment has been minimized.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@lpinca

lpinca approved these changes Nov 18, 2018

@oyyd oyyd added the fast-track label Nov 18, 2018

@oyyd

This comment has been minimized.

Copy link
Contributor Author

commented Nov 18, 2018

Landed in 34eccb2. Thanks!

@oyyd oyyd closed this Nov 18, 2018

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Nov 18, 2018

doc: fix missing PR id of 23329
PR-URL: nodejs#24458
Refs: nodejs#23329
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@targos targos added this to Don't land (ever) in v11.x Nov 20, 2018

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

doc: fix missing PR id of 23329
PR-URL: nodejs#24458
Refs: nodejs#23329
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.