Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use arraysize instead of hardcode number #24473

Closed
wants to merge 2 commits into from

Conversation

@leeight
Copy link
Contributor

commented Nov 19, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@leeight leeight force-pushed the leeight:use-arrarysize branch 3 times, most recently from a52e8d4 to 2c35649 Nov 19, 2018

@sagirk
sagirk approved these changes Nov 19, 2018

@leeight leeight force-pushed the leeight:use-arrarysize branch from 2c35649 to cb4a1b1 Nov 20, 2018

src/node_url.cc Outdated Show resolved Hide resolved

@leeight leeight force-pushed the leeight:use-arrarysize branch from cb4a1b1 to c05fa48 Nov 21, 2018

@addaleax

This comment has been minimized.

@refack
Copy link
Member

left a comment

Added three suggestions.

src/node_os.cc Outdated Show resolved Hide resolved

@leeight leeight force-pushed the leeight:use-arrarysize branch from c05fa48 to f059332 Nov 23, 2018

@refack
refack approved these changes Nov 23, 2018
Copy link
Member

left a comment

💯 Thanks you!

@leeight leeight force-pushed the leeight:use-arrarysize branch from f059332 to 22fc963 Nov 23, 2018

@addaleax

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

Looks like the most recent changes broke Travis?

@addaleax addaleax removed the author ready label Nov 23, 2018

src/node_os.cc Outdated Show resolved Hide resolved

@leeight leeight force-pushed the leeight:use-arrarysize branch from 22fc963 to 49ada82 Nov 24, 2018

@refack

This comment has been minimized.

@refack
refack approved these changes Nov 24, 2018

@refack refack added the author ready label Nov 24, 2018

src/util.h Outdated Show resolved Hide resolved

@addaleax addaleax removed the author ready label Nov 24, 2018

src: Update src/util.h
Co-Authored-By: leeight <leeight@gmail.com>
@refack

This comment has been minimized.

Copy link
Member

commented Nov 24, 2018

@refack refack self-assigned this Nov 24, 2018

@refack

This comment has been minimized.

Copy link
Member

commented Nov 24, 2018

P.S. I'm self-assigned this so I'll get notifications from GitHub, and so that I will not lose track of it and help steward it to completion.

@addaleax

This comment has been minimized.

Copy link
Member

commented Dec 1, 2018

Landed in adbf947, thanks for the PR! 🎉

By the way, if your PR doesn’t receive much attention within a day or two, and you think it’s ready to go, feel free to bump the thread by commenting (e.g. “bump” or pinging involved individuals like me). 🙂

@addaleax addaleax closed this Dec 1, 2018

addaleax added a commit that referenced this pull request Dec 1, 2018
src: use arraysize instead of hardcode number
PR-URL: #24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
src: use arraysize instead of hardcode number
PR-URL: #24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
src: use arraysize instead of hardcode number
PR-URL: nodejs#24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
src: use arraysize instead of hardcode number
PR-URL: #24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
src: use arraysize instead of hardcode number
PR-URL: #24473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@refack refack removed their assignment Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.