Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use print() function in both Python 2 and 3 #24485

Merged
merged 0 commits into from Nov 19, 2018

Conversation

@cclauss
Copy link
Contributor

commented Nov 19, 2018

A subset of #23669 to simplify the review process. @refack

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss cclauss force-pushed the cclauss:print-function branch from 13efdb6 to 9e15693 Nov 19, 2018

@refack
refack approved these changes Nov 19, 2018
@refack

This comment has been minimized.

@refack

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

Reviewers please 👍 for fast-tracking this. It's a simple refactoring to non-code tooling.

@targos
targos approved these changes Nov 19, 2018

@refack refack force-pushed the cclauss:print-function branch from 9e15693 to cde8270 Nov 19, 2018

refack added a commit to cclauss/node that referenced this pull request Nov 19, 2018
test: use print() function on both Python 2 and 3
PR-URL: nodejs#24485
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@refack refack force-pushed the cclauss:print-function branch from cde8270 to c7c711b Nov 19, 2018

refack added a commit to cclauss/node that referenced this pull request Nov 19, 2018
test: use print() function on both Python 2 and 3
PR-URL: nodejs#24485
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@refack refack force-pushed the cclauss:print-function branch from c7c711b to 5f25dd1 Nov 19, 2018

@refack refack removed the author ready label Nov 19, 2018

@Trott Trott merged commit 5f25dd1 into nodejs:master Nov 19, 2018

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details
@refack

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

For some reason GitHub thinks this was merged by Trott.
FTR it was merged by me: Landed in 5f25dd1

@cclauss cclauss deleted the cclauss:print-function branch Nov 19, 2018

targos added a commit that referenced this pull request Nov 19, 2018
test: use print() function on both Python 2 and 3
PR-URL: #24485
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: use print() function on both Python 2 and 3
PR-URL: #24485
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
test: use print() function on both Python 2 and 3
PR-URL: #24485
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: use print() function on both Python 2 and 3
PR-URL: nodejs#24485
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: use print() function on both Python 2 and 3
PR-URL: #24485
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: use print() function on both Python 2 and 3
PR-URL: #24485
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.