Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise `author ready` explanation #24558

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Nov 21, 2018

Improve the author ready text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.
@richardlau
Copy link
Member

left a comment

It feels as if applying/removing the label could be something automatable with the github-bot.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott Trott added the fast-track label Nov 21, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 21, 2018

Landed in 7cc3b1e

@Trott Trott closed this Nov 21, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2018
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: nodejs#24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos added a commit that referenced this pull request Nov 24, 2018
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: nodejs#24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
doc: revise `author ready` explanation
Improve the `author ready` text in the COLLABORATOR_GUIDE for
scannability, readability, etc.

PR-URL: #24558
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.