Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add information to assertion #24566

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Nov 22, 2018

test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

Refs: #24565

Collaborators 馃憤 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added fast-track and removed test labels Nov 22, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2018

@Trott Trott force-pushed the Trott:more-data branch from 8927c6e to 935dc86 Nov 22, 2018

test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

Refs: #24565

@Trott Trott force-pushed the Trott:more-data branch from 935dc86 to c186d46 Nov 22, 2018

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2018

CI since improving and force-pushing: https://ci.nodejs.org/job/node-test-pull-request/18886/

@Trott

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2018

@danbev
danbev approved these changes Nov 23, 2018
@danbev

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

Landed in b303d8b.

@danbev danbev closed this Nov 23, 2018

danbev added a commit that referenced this pull request Nov 23, 2018
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos added a commit that referenced this pull request Nov 24, 2018
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
codebytere added a commit that referenced this pull request Jan 13, 2019
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: nodejs#24566
Refs: nodejs#24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@codebytere codebytere referenced this pull request Jan 15, 2019
MylesBorins added a commit that referenced this pull request Jan 29, 2019
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere added a commit that referenced this pull request Jan 29, 2019
test: add information to assertion
test-fs-stat-bigint.js failed once in CI but there wasn't enough
information to know what was giong on. Adding a bit of information to
the assertion that failed in case it fails again.

PR-URL: #24566
Refs: #24565
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.