Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: simplify LibuvStreamWrap::DoWrite #24588

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Nov 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax

This comment has been minimized.

Copy link
Member Author

commented Nov 24, 2018

@addaleax addaleax added the lib / src label Nov 24, 2018

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Nov 24, 2018

@danbev

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Landed in 5e2ecd4.

@danbev danbev closed this Nov 29, 2018

danbev added a commit that referenced this pull request Nov 29, 2018
src: simplify LibuvStreamWrap::DoWrite
PR-URL: #24588
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Nov 29, 2018
src: simplify LibuvStreamWrap::DoWrite
PR-URL: #24588
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
src: simplify LibuvStreamWrap::DoWrite
PR-URL: nodejs#24588
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

This change does not land cleanly on v10.x-staging. I've added the backport-requested-v10.x label, but feel free to swap to dont-land-on- if this change shouldn't land on v10.x.

@addaleax addaleax deleted the addaleax:simplify-dowrite branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.