Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: chenged anonymous function to arrow function #24589

Closed

Conversation

@taishikato
Copy link
Contributor

@taishikato taishikato commented Nov 24, 2018

I changed 2 anonymous functions to arrow functions.

Checklist
@taishikato taishikato force-pushed the fix-http-clinet-arror-method branch from 5ee7dbd to a90b1d1 Nov 24, 2018
@ronkorving
Copy link
Contributor

@ronkorving ronkorving commented Nov 24, 2018

大丈夫そうですが、GitHub descriptionによると2つのfunctionをアローにしましたが、diffを見るなら1つしかないです。その1つは良さそうと思います。

@taishikato
Copy link
Contributor Author

@taishikato taishikato commented Nov 24, 2018

@ronkorving 最初は2つ修正したのですが、適切ではなかったため最終的に1つだけにしました

Leko
Leko approved these changes Nov 24, 2018
@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Nov 24, 2018

@Trott
Copy link
Member

@Trott Trott commented Nov 24, 2018

Whoever lands this should fix up the commit message (chenged -> change).

Trott
Trott approved these changes Nov 24, 2018
@gireeshpunathil
Copy link
Member

@gireeshpunathil gireeshpunathil commented Nov 26, 2018

landed as 39d25eb

thank you @taishikato for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps

gireeshpunathil added a commit that referenced this issue Nov 26, 2018
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
targos added a commit that referenced this issue Nov 27, 2018
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
rvagg added a commit that referenced this issue Nov 28, 2018
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack added a commit to refack/node that referenced this issue Jan 14, 2019
PR-URL: nodejs#24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs pushed a commit that referenced this issue Feb 11, 2019
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
rvagg added a commit that referenced this issue Feb 28, 2019
PR-URL: #24589
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants