Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix assert.strictEqual #24594

Closed

Conversation

@hyokenmi
Copy link

commented Nov 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
feng jianmei feng jianmei
@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 24, 2018

looks like #24592 also addresses the same file. can you please discuss with @na9amura and probably pick up another assignment?

@Leko
Leko approved these changes Nov 24, 2018
@Trott

This comment has been minimized.

@Trott Trott added the author ready label Nov 25, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 25, 2018

looks like @24592 and #24610 were closed in favor of this; so all set for this PR. fast-track? pls 👍

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

Landed in 46094e4.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 28, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018
test: fix argument order in assert.strictEqual
PR-URL: nodejs#24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@hyokenmi hyokenmi deleted the hyokenmi:bugfix-test-child-process-cwd branch Nov 28, 2018

targos added a commit that referenced this pull request Nov 28, 2018
test: fix argument order in assert.strictEqual
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: fix argument order in assert.strictEqual
PR-URL: nodejs#24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: fix argument order in assert.strictEqual
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
test: fix argument order in assert.strictEqual
PR-URL: #24594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.