Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: convert to arrow function in fs.js #24604

Closed
wants to merge 1 commit into from

Conversation

@exoego
Copy link
Contributor

commented Nov 24, 2018

As far as I look, there are no this reference in the converted functions.

Named functions like function tick and function oncomplete are left untouched to preserve stack traces.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@oyyd
oyyd approved these changes Nov 24, 2018
Copy link
Member

left a comment

LGTM

@Leko
Leko approved these changes Nov 24, 2018
@gireeshpunathil

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Landed in 32b0958.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 29, 2018
lib: convert to arrow function in fs.js
PR-URL: nodejs#24604
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@exoego exoego deleted the exoego:arrow-func-fs branch Nov 29, 2018

targos added a commit that referenced this pull request Nov 29, 2018
lib: convert to arrow function in fs.js
PR-URL: #24604
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
lib: convert to arrow function in fs.js
PR-URL: nodejs#24604
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
lib: convert to arrow function in fs.js
PR-URL: #24604
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
lib: convert to arrow function in fs.js
PR-URL: #24604
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.