Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix http2-binding strictEqual order #24616

Conversation

@dominikeinkemmer
Copy link
Contributor

commented Nov 24, 2018

Refs: nodejsjp#1

Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js
@gireeshpunathil

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 24, 2018

fast-track? pls 👍

@targos targos added the fast-track label Nov 24, 2018

@targos
targos approved these changes Nov 24, 2018
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 24, 2018

Landed in a57343c.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 24, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 24, 2018
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: nodejs#24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos added a commit that referenced this pull request Nov 25, 2018
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: nodejs#24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs added a commit that referenced this pull request Feb 11, 2019
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
test: fix http2-binding strictEqual order
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.