Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the arguments order in assert.strictEqual #24620

Closed
wants to merge 1 commit into from

Conversation

@pastak
Copy link
Contributor

commented Nov 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Nov 24, 2018
@gireeshpunathil

This comment has been minimized.

@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 25, 2018

fast-track? pls 👍

@Leko
Leko approved these changes Nov 26, 2018
@shisama

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

single failure in arm-fanned is:

22:29:48 not ok 311 known_issues/test-vm-timeout-escape-nexttick
22:29:48   ---
22:29:48   duration_ms: 2.80
22:29:48   severity: fail
22:29:48   stack: |-
22:29:48   ...
@gireeshpunathil

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@Trott - should I get this test under ./test/known_issues/known_issues.status through a PR? pls let me know.

@gireeshpunathil gireeshpunathil referenced this pull request Nov 29, 2018
2 of 4 tasks complete
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@Trott - should I get this test under ./test/known_issues/known_issues.status through a PR? pls let me know.

Probably a good idea if we've seen it more than once (which we have). I mean, unless there's an obvious fix (which there probably isn't).

Errr...that was a long-winded way of saying, "Yes, sounds like a good idea to me."

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 29, 2018
test: mark test-vm-timeout-escape-nexttick flaky
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: nodejs#24712
Refs: nodejs#24620
Refs: nodejs#24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Now that the super-problematic test is marked as flaky, let's do a re-run from scratch (so that we get that flaky status marking in the CI for this) and hopefully this passes no problem: https://ci.nodejs.org/job/node-test-pull-request/19055/

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

Landed in 97fedef.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 29, 2018
test: fix the arguments order in assert.strictEqual
PR-URL: nodejs#24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
targos added a commit that referenced this pull request Nov 29, 2018
test: mark test-vm-timeout-escape-nexttick flaky
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos added a commit that referenced this pull request Nov 29, 2018
test: fix the arguments order in assert.strictEqual
PR-URL: #24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BridgeAR BridgeAR referenced this pull request Dec 5, 2018
4 of 4 tasks complete
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: mark test-vm-timeout-escape-nexttick flaky
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: nodejs#24712
Refs: nodejs#24620
Refs: nodejs#24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
test: fix the arguments order in assert.strictEqual
PR-URL: nodejs#24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: mark test-vm-timeout-escape-nexttick flaky
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs added a commit that referenced this pull request Feb 12, 2019
test: fix the arguments order in assert.strictEqual
PR-URL: #24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BethGriggs BethGriggs referenced this pull request Feb 12, 2019
rvagg added a commit that referenced this pull request Feb 28, 2019
test: mark test-vm-timeout-escape-nexttick flaky
This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

PR-URL: #24712
Refs: #24620
Refs: #24120
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
test: fix the arguments order in assert.strictEqual
PR-URL: #24620
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.